From 2653cdbe3ecbeea6287e769b6d904cd81cd1486e Mon Sep 17 00:00:00 2001 From: AKORA <65976562+A-K-O-R-A@users.noreply.github.com> Date: Tue, 8 Oct 2024 10:18:03 +0200 Subject: [PATCH] Rename sitePrefrence property names to match the matching global setting property names --- .../content/keepassxc-browser.js | 2 +- keepassxc-browser/content/totp-field.js | 2 +- keepassxc-browser/options/options.html | 8 +++---- keepassxc-browser/options/options.js | 22 +++++++++---------- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/keepassxc-browser/content/keepassxc-browser.js b/keepassxc-browser/content/keepassxc-browser.js index 41049de..13ea78f 100755 --- a/keepassxc-browser/content/keepassxc-browser.js +++ b/keepassxc-browser/content/keepassxc-browser.js @@ -503,7 +503,7 @@ kpxc.prepareCredentials = async function() { } if (kpxc.credentials.length === 1) { - if (kpxc.preferencesForPage?.autoFillCredentials || kpxc.settings.autoFillSingleEntry) { + if (kpxc.preferencesForPage?.autoFillSingleEntry || kpxc.settings.autoFillSingleEntry) { kpxcFill.fillFromAutofill(); return; } diff --git a/keepassxc-browser/content/totp-field.js b/keepassxc-browser/content/totp-field.js index 2608108..a50dc9c 100644 --- a/keepassxc-browser/content/totp-field.js +++ b/keepassxc-browser/content/totp-field.js @@ -106,7 +106,7 @@ class TOTPFieldIcon extends Icon { // Fill TOTP automatically if option is enabled TOTPFieldIcon.prototype.autoFillSingleTotp = async function(field) { - if (kpxc.preferencesForPage?.autoFillTOTP || kpxc.settings.autoFillSingleTotp) { + if (kpxc.preferencesForPage?.autoFillSingleTotp || kpxc.settings.autoFillSingleTotp) { if (kpxc.credentials.length === 0) { await kpxc.receiveCredentialsIfNecessary(); } diff --git a/keepassxc-browser/options/options.html b/keepassxc-browser/options/options.html index 26695d4..fd58fbb 100644 --- a/keepassxc-browser/options/options.html +++ b/keepassxc-browser/options/options.html @@ -798,16 +798,16 @@
- - + +
- - + +
diff --git a/keepassxc-browser/options/options.js b/keepassxc-browser/options/options.js index 971532e..4f0faab 100644 --- a/keepassxc-browser/options/options.js +++ b/keepassxc-browser/options/options.js @@ -547,10 +547,10 @@ options.initSitePreferences = function() { site.allowIframes = this.checked; } else if (this.name === 'autoSubmit') { site.autoSubmit = this.checked; - } else if (this.name === 'autoFillCredentials') { - site.autoFillCredentials = this.checked; - } else if (this.name === 'autoFillTOTP') { - site.autoFillTOTP = this.checked; + } else if (this.name === 'autoFillSingleEntry') { + site.autoFillSingleEntry = this.checked; + } else if (this.name === 'autoFillSingleTotp') { + site.autoFillSingleTotp = this.checked; } } } @@ -571,7 +571,7 @@ options.initSitePreferences = function() { options.saveSettings(); }; - const addNewRow = function(rowClone, newIndex, url, ignore, usernameOnly, improvedFieldDetection, allowIframes, autoSubmit, autoFillCredentials, autoFillTOTP) { + const addNewRow = function(rowClone, newIndex, url, ignore, usernameOnly, improvedFieldDetection, allowIframes, autoSubmit, autoFillSingleEntry, autoFillSingleTotp) { const row = rowClone.cloneNode(true); row.setAttribute('url', url); row.setAttribute('id', 'tr-scf' + newIndex); @@ -588,10 +588,10 @@ options.initSitePreferences = function() { details.querySelector('#allowIframes').addEventListener('change', checkboxClicked); details.querySelector('#autoSubmit').checked = autoSubmit; details.querySelector('#autoSubmit').addEventListener('change', checkboxClicked); - details.querySelector('#autoFillCredentials').checked = autoFillCredentials; - details.querySelector('#autoFillCredentials').addEventListener('change', checkboxClicked); - details.querySelector('#autoFillTOTP').checked = autoFillTOTP; - details.querySelector('#autoFillTOTP').addEventListener('change', checkboxClicked); + details.querySelector('#autoFillSingleEntry').checked = autoFillSingleEntry; + details.querySelector('#autoFillSingleEntry').addEventListener('change', checkboxClicked); + details.querySelector('#autoFillSingleTotp').checked = autoFillSingleTotp; + details.querySelector('#autoFillSingleTotp').addEventListener('change', checkboxClicked); details.querySelector('#deleteButton').addEventListener('click', removeButtonClicked); $('#tab-site-preferences #sitePreferencesTable').append(row); @@ -682,8 +682,8 @@ options.initSitePreferences = function() { site.improvedFieldDetection, site.allowIframes, site.autoSubmit, - site.autoFillCredentials, - site.autoFillTOTP, + site.autoFillSingleEntry, + site.autoFillSingleTotp, ); ++counter; }