From 16e08b470bb81c5b3672764a39a7511a8868b619 Mon Sep 17 00:00:00 2001 From: varjolintu Date: Tue, 2 Feb 2021 07:54:42 +0200 Subject: [PATCH] Add missing checks for StringFields --- keepassxc-browser/content/keepassxc-browser.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/keepassxc-browser/content/keepassxc-browser.js b/keepassxc-browser/content/keepassxc-browser.js index 798b9d1..f40c9b6 100755 --- a/keepassxc-browser/content/keepassxc-browser.js +++ b/keepassxc-browser/content/keepassxc-browser.js @@ -941,7 +941,7 @@ kpxc.fillInCredentials = async function(combination, predefinedUsername, uuid, p } // Fill StringFields - if (selectedCredentials.stringFields.length > 0) { + if (selectedCredentials.stringFields && selectedCredentials.stringFields.length > 0) { kpxc.fillInStringFields(combination.fields, selectedCredentials.stringFields); } @@ -1502,7 +1502,7 @@ kpxc.updateTOTPList = async function() { const password = kpxc.credentials[index].password; // If no username is set, compare with a password - const credentialList = kpxc.credentials.filter(c => (c.totp || c.stringFields.some(s => s['KPH: {TOTP}'])) + const credentialList = kpxc.credentials.filter(c => (c.totp || (c.stringFields && c.stringFields.some(s => s['KPH: {TOTP}']))) && (c.login === username || (!username && c.password === password))); // Filter TOTP Autocomplete Menu with matching 2FA credentials