From 16a304f6c0bc35ea35464e376c85f334daad4b27 Mon Sep 17 00:00:00 2001
From: AKORA <65976562+A-K-O-R-A@users.noreply.github.com>
Date: Mon, 7 Oct 2024 17:37:44 +0200
Subject: [PATCH] Show delete button when not expanded

---
 keepassxc-browser/options/options.css  | 25 +++++++++++++++++++++++++
 keepassxc-browser/options/options.html | 15 +++++++++------
 keepassxc-browser/options/options.js   |  2 +-
 3 files changed, 35 insertions(+), 7 deletions(-)

diff --git a/keepassxc-browser/options/options.css b/keepassxc-browser/options/options.css
index 585154a..95ca2ff 100644
--- a/keepassxc-browser/options/options.css
+++ b/keepassxc-browser/options/options.css
@@ -242,3 +242,28 @@ table td:last-of-type {
         max-width: calc(0.8333333333 * 1440px);
     }
 }
+
+
+#sitePreferencesTable > li > details > summary {
+    list-style: none;
+    vertical-align: middle;
+}
+
+#sitePreferencesTable > li > details > summary::-webkit-details-marker {
+    display: none;
+}
+
+#sitePreferencesTable > li > details > summary > div > div:first-child{
+    display: flex;
+    align-items: center;
+}
+
+#sitePreferencesTable > li > details > summary > div > div:first-child::before {
+    content: '►';
+    padding-right: 1rem;
+}
+
+#sitePreferencesTable > li > details[open] > summary > div > div:first-child::before {
+    content: '▼';
+    padding-right: 1rem;
+}
diff --git a/keepassxc-browser/options/options.html b/keepassxc-browser/options/options.html
index 454ef89..4a7d078 100644
--- a/keepassxc-browser/options/options.html
+++ b/keepassxc-browser/options/options.html
@@ -742,7 +742,15 @@
                       <li class="clone d-none list-group-item">
                         <details>
                           <summary>
-                            <span></span>
+                            <div class="row justify-content-between">
+                              <div class="col-auto"></div>
+                              <div class="col-auto">
+                                <button id="deleteButton" class="btn btn-sm delete btn-danger btn" data-i18n="[title]removeSitePreferencesButtonTitle">
+                                  <i class="fa fa-remove" aria-hidden="true"></i>
+                                  <span data-i18n="optionsButtonRemove"></span>
+                                </button>
+                              </div>
+                            </div>
                           </summary>
 
                           <div class="m-3">
@@ -800,11 +808,6 @@
                                 <div class="form-text" data-i18n="optionsAutoFillSingleTotpHelpText"></div>
                               </div>
                             </div>
-
-                            <button id="deleteButton" class="btn btn-sm delete btn-danger btn mt-3" data-i18n="[title]removeSitePreferencesButtonTitle">
-                              <i class="fa fa-remove" aria-hidden="true"></i>
-                              <span data-i18n="optionsButtonRemove"></span>
-                            </button>
                           </div>
                         </details>
                       </li>
diff --git a/keepassxc-browser/options/options.js b/keepassxc-browser/options/options.js
index 45cfa91..971532e 100644
--- a/keepassxc-browser/options/options.js
+++ b/keepassxc-browser/options/options.js
@@ -577,7 +577,7 @@ options.initSitePreferences = function() {
         row.setAttribute('id', 'tr-scf' + newIndex);
 
         const details = row.children[0];
-        details.children[0].children[0].textContent = url;
+        details.children[0].children[0].children[0].textContent = url;
         details.querySelector('#ignore').value = ignore;
         details.querySelector('#ignore').addEventListener('change', selectionChanged);
         details.querySelector('#usernameOnly').checked = usernameOnly;