From 0070bebf3df0b468c365b185391d082501251d34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sami=20V=C3=A4nttinen?= Date: Fri, 11 Jan 2019 15:58:22 +0200 Subject: [PATCH] Fix version comparison (#376) --- keepassxc-browser/background/keepass.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/keepassxc-browser/background/keepass.js b/keepassxc-browser/background/keepass.js index 1499487..f813c63 100755 --- a/keepassxc-browser/background/keepass.js +++ b/keepassxc-browser/background/keepass.js @@ -795,7 +795,7 @@ keepass.keePassXCUpdateAvailable = function() { } } - return keepass.compareVersion(keepass.currentKeePassXC, keepass.latestKeePassXC.version); + return keepass.compareVersion(keepass.currentKeePassXC, keepass.latestKeePassXC.version, false); }; keepass.checkForNewKeePassXCVersion = function() { @@ -1070,12 +1070,12 @@ keepass.updateDatabase = function() { }, null); }; -keepass.compareVersion = function(minimum, current) { +keepass.compareVersion = function(minimum, current, canBeEqual = true) { if (!minimum || !current) { return false; } const min = minimum.split('.', 3).map(s => s.padStart(4, '0')).join('.'); const cur = current.split('.', 3).map(s => s.padStart(4, '0')).join('.'); - return min <= cur; + return (canBeEqual ? (min <= cur) : (min < cur)); };