prehistoric-systems/fail2ban
1
0
Fork 0
mirror of https://github.com/fail2ban/fail2ban.git synced 2026-03-11 08:55:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test Ticket.getIP() return value type

Browse source 
This covers the original problem where getIP() would return a str
when it should be an IPAddr. One testcase fails now.
This commit is contained in:
Marko Hauptvogel 2025-11-10 14:29:58 +01:00
parent 3f78f1520b
commit cafea3235f
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
fail2ban/tests/tickettestcase.py
View file

@ -26,6 +26,7 @@ from ..server.mytime import MyTime
import unittest
from ..server.ticket import Ticket, FailTicket, BanTicket
from ..server.ipdns import IPAddr
class TicketTests(unittest.TestCase):
@ -40,6 +41,7 @@ class TicketTests(unittest.TestCase):
# Ticket
t = Ticket('193.168.0.128', tm, matches)
self.assertEqual(t.getID(), '193.168.0.128')
self.assertIsInstance(t.getIP(), IPAddr)
self.assertEqual(t.getIP(), '193.168.0.128')
self.assertEqual(t.getTime(), tm)
self.assertEqual(t.getMatches(), matches2)
@ -67,6 +69,7 @@ class TicketTests(unittest.TestCase):
ft = FailTicket('193.168.0.128', tm, matches)
ft.setBanTime(60*60)
self.assertEqual(ft.getID(), '193.168.0.128')
self.assertIsInstance(t.getIP(), IPAddr)
self.assertEqual(ft.getIP(), '193.168.0.128')
self.assertEqual(ft.getTime(), tm)
self.assertEqual(ft.getMatches(), matches2)
@ -110,6 +113,7 @@ class TicketTests(unittest.TestCase):
# copy all from another ticket:
ft2 = FailTicket(ticket=ft)
self.assertEqual(ft, ft2)
self.assertEqual(ft.getIP(), ft2.getIP())
self.assertEqual(ft.getData(), ft2.getData())
self.assertEqual(ft2.getAttempt(), 4)
self.assertEqual(ft2.getRetry(), 7)
@ -123,10 +127,12 @@ class TicketTests(unittest.TestCase):
# different ID (string) and IP:
t = Ticket('123-456-678', tm, data={'ip':'192.0.2.1'})
self.assertEqual(t.getID(), '123-456-678')
self.assertIsInstance(t.getIP(), IPAddr)
self.assertEqual(t.getIP(), '192.0.2.1')
# different ID (tuple) and IP:
t = Ticket(('192.0.2.1', '5000'), tm, data={'ip':'192.0.2.1'})
self.assertEqual(t.getID(), ('192.0.2.1', '5000'))
self.assertIsInstance(t.getIP(), IPAddr)
self.assertEqual(t.getIP(), '192.0.2.1')
def testTicketFlags(self):