From 2a4dafce5b8b583f2a914dd38d6add8bd4addd16 Mon Sep 17 00:00:00 2001 From: Sander Hoentjen Date: Mon, 8 May 2017 14:11:07 +0200 Subject: [PATCH] don't call setLogTarget from setSyslogSocket when holding the lock If we do, setLogTarget will wait for the lock, but it will never be released --- fail2ban/server/server.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fail2ban/server/server.py b/fail2ban/server/server.py index facbe393..56367ed7 100644 --- a/fail2ban/server/server.py +++ b/fail2ban/server/server.py @@ -638,9 +638,9 @@ class Server: if self.__syslogSocket == syslogsocket: return True self.__syslogSocket = syslogsocket - # Conditionally reload, logtarget depends on socket path when SYSLOG - return self.__logTarget != "SYSLOG"\ - or self.setLogTarget(self.__logTarget) + # Conditionally reload, logtarget depends on socket path when SYSLOG + return self.__logTarget != "SYSLOG"\ + or self.setLogTarget(self.__logTarget) def getLogTarget(self): with self.__loggingLock: