From c15e968c1fda97219e27ef210fc146d7668b1f27 Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Thu, 14 Jul 2016 21:17:18 -0400 Subject: [PATCH] DOC: added a note about choose correct branch for PR --- .github/PULL_REQUEST_TEMPLATE.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a9fff350..3a17ccc2 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,9 +1,11 @@ Before submitting your PR, please review the following checklist: +- [ ] **CHOOSE CORRECT BRANCH**: if filing a bugfix/enhancement + against 0.9.x series, choose `master` branch - [ ] **CONSIDER adding a unit test** if your PR resolves an issue - [ ] **LIST ISSUES** this PR resolves -- [ ] **MAKE SURE** this PR doesn't break existing tests +- [ ] **MAKE SURE** this PR doesn't break existing tests - [ ] **KEEP PR small** so it could be easily reviewed. - [ ] **AVOID** making unnecessary stylistic changes in unrelated code -- [ ] **ACCOMPANY** each new `failregex` for filter `X` with sample log lines - within `fail2ban/tests/files/logs/X` file \ No newline at end of file +- [ ] **ACCOMPANY** each new `failregex` for filter `X` with sample log lines + within `fail2ban/tests/files/logs/X` file