prehistoric-systems/coolify
1
0
Fork 0
mirror of https://github.com/coollabsio/coolify.git synced 2026-03-11 08:55:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

feat: add --runtime support for custom docker run options

Browse source 
This enables users to specify container runtimes like gVisor (runsc)
via the Custom Docker Run Options field.

Example usage: --runtime=runsc

This is useful for running untrusted workloads in sandboxed runtimes
that provide additional isolation beyond standard runc.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Augustinas Malinauskas 2026-02-01 17:51:55 -08:00
parent 3b68914b73
commit c4e15d4e1b
2 changed files with 37 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
bootstrap/helpers/docker.php
View file

@ -1009,6 +1009,7 @@ function convertDockerRunToCompose(?string $custom_docker_run_options = null)
'--gpus' => 'gpus',
'--hostname' => 'hostname',
'--entrypoint' => 'entrypoint',
'--runtime' => 'runtime',
]);
foreach ($matches as $match) {
$option = $match[1];
@ -1029,6 +1030,16 @@ function convertDockerRunToCompose(?string $custom_docker_run_options = null)
$options[$option] = array_unique($options[$option]);
}
}
if ($option === '--runtime') {
// Match --runtime=value or --runtime value (e.g., --runtime=runsc, --runtime runc)
$regexForParsingRuntime = '/--runtime(?:=|\s+)([^\s]+)/';
preg_match($regexForParsingRuntime, $custom_docker_run_options, $runtime_matches);
$value = $runtime_matches[1] ?? null;
if ($value && ! empty(trim($value))) {
$options[$option][] = $value;
$options[$option] = array_unique($options[$option]);
}
}
if ($option === '--entrypoint') {
$value = null;
// Match --entrypoint=value or --entrypoint value
@ -1097,7 +1108,7 @@ function convertDockerRunToCompose(?string $custom_docker_run_options = null)
}
});
$compose_options->put($mapping[$option], $ulimits);
} elseif ($option === '--shm-size' || $option === '--hostname') {
} elseif ($option === '--shm-size' || $option === '--hostname' || $option === '--runtime') {
if (! is_null($value) && is_array($value) && count($value) > 0 && ! empty(trim($value[0]))) {
$compose_options->put($mapping[$option], $value[0]);
}

25
tests/Feature/DockerCustomCommandsTest.php
View file

@ -198,3 +198,28 @@ test('ConvertEntrypointSingleQuotedWithDoubleQuotesInside', function () {
'entrypoint' => 'python -c "print(\"hi\")"',
]);
});
test('RuntimeWithEquals', function () {
$input = '--runtime=runsc';
$output = convertDockerRunToCompose($input);
expect($output)->toBe([
'runtime' => 'runsc',
]);
});
test('RuntimeWithoutEquals', function () {
$input = '--runtime runsc';
$output = convertDockerRunToCompose($input);
expect($output)->toBe([
'runtime' => 'runsc',
]);
});
test('RuntimeWithOtherOptions', function () {
$input = '--runtime=runsc --cap-drop=ALL --security-opt=no-new-privileges';
$output = convertDockerRunToCompose($input);
expect($output)->toHaveKeys(['runtime', 'cap_drop', 'security_opt'])
->and($output['runtime'])->toBe('runsc')
->and($output['cap_drop'])->toBe(['ALL'])
->and($output['security_opt'])->toBe(['no-new-privileges']);
});