From 96a93bfe2a073080cd70514f9c8c730eca25f512 Mon Sep 17 00:00:00 2001
From: Dominic <dominic.schmid@hotmail.com>
Date: Sun, 11 Jan 2026 05:45:19 +0100
Subject: [PATCH] refactor(limits): enhance validation rules and UI for CPU
 limits

---
 app/Livewire/Project/Shared/ResourceLimits.php     | 14 +++++++-------
 .../project/shared/resource-limits.blade.php       |  4 ++--
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/Livewire/Project/Shared/ResourceLimits.php b/app/Livewire/Project/Shared/ResourceLimits.php
index 0b3840289..e03934845 100644
--- a/app/Livewire/Project/Shared/ResourceLimits.php
+++ b/app/Livewire/Project/Shared/ResourceLimits.php
@@ -31,9 +31,9 @@ class ResourceLimits extends Component
         'limitsMemorySwap' => 'required|string',
         'limitsMemorySwappiness' => 'required|integer|min:0|max:100',
         'limitsMemoryReservation' => 'required|string',
-        'limitsCpus' => 'nullable',
-        'limitsCpuset' => 'nullable',
-        'limitsCpuShares' => 'nullable',
+        'limitsCpus' => 'nullable|numeric|min:0|max:1024',
+        'limitsCpuset' => 'nullable|string',
+        'limitsCpuShares' => 'nullable|integer|min:0|max:8192',
     ];
 
     protected $validationAttributes = [
@@ -85,19 +85,19 @@ class ResourceLimits extends Component
             $this->authorize('update', $this->resource);
 
             // Apply default values to properties
-            if (! $this->limitsMemory) {
+            if (!$this->limitsMemory) {
                 $this->limitsMemory = '0';
             }
-            if (! $this->limitsMemorySwap) {
+            if (!$this->limitsMemorySwap) {
                 $this->limitsMemorySwap = '0';
             }
             if (is_null($this->limitsMemorySwappiness)) {
                 $this->limitsMemorySwappiness = 60;
             }
-            if (! $this->limitsMemoryReservation) {
+            if (!$this->limitsMemoryReservation) {
                 $this->limitsMemoryReservation = '0';
             }
-            if (! $this->limitsCpus) {
+            if (!$this->limitsCpus) {
                 $this->limitsCpus = '0';
             }
             if ($this->limitsCpuset === '') {
diff --git a/resources/views/livewire/project/shared/resource-limits.blade.php b/resources/views/livewire/project/shared/resource-limits.blade.php
index 7793f9cda..b88d1edee 100644
--- a/resources/views/livewire/project/shared/resource-limits.blade.php
+++ b/resources/views/livewire/project/shared/resource-limits.blade.php
@@ -10,7 +10,7 @@
                 <h3>Limit CPUs</h3>
                 <div class="flex flex-col gap-4">
                     <div class="flex flex-col md:flex-row gap-4">
-                        <x-forms.input canGate="update" :canResource="$resource" type="number" min="0" step="0.1"
+                        <x-forms.input canGate="update" :canResource="$resource" type="number" min="0" max="1024" step="0.1"
                             placeholder="1.5"
                             helper="Limit how much CPU the container can use. 0 means unlimited (use all available CPUs). Use decimal numbers like 1.5 for one and a half CPUs, or 0.5 for half a CPU.<br>More info <a class='underline dark:text-white' target='_blank' href='https://docs.docker.com/engine/reference/run/#cpu-quota-constraint'>cpu-quota</a>."
                             label="CPU Limit" id="limitsCpus">
@@ -46,7 +46,7 @@
                                 </svg>
                             </x-slot:suffix>
                         </x-forms.input>
-                        <x-forms.input canGate="update" :canResource="$resource" type="number" min="0" step="64"
+                        <x-forms.input canGate="update" :canResource="$resource" type="number" min="0" max="8192" step="64"
                             placeholder="1024"
                             helper="Relative CPU priority when containers compete for resources. Default: 1024 (normal). Examples: 512 = half priority, 2048 = double priority.<br>More info <a class='underline dark:text-white' target='_blank' href='https://docs.docker.com/engine/reference/run/#cpu-share-constraint'>cpu_shares</a>."
                             label="CPU Weight" id="limitsCpuShares">