From f7c0b3078eea3de090e122a1c065b82ca578bc30 Mon Sep 17 00:00:00 2001 From: Rebecca Breu Date: Fri, 14 May 2021 14:03:44 +0200 Subject: [PATCH] Fix unittests --- tests/test_config.py | 2 +- tests/test_utils.py | 9 ++++++--- tests/test_view.py | 2 +- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/test_config.py b/tests/test_config.py index 9f93546..a418579 100644 --- a/tests/test_config.py +++ b/tests/test_config.py @@ -40,7 +40,7 @@ class BeeSettingsRecentFilesTestCase(BeeTestCase): self.settings.get_recent_files() == [] def test_get_existing_only(self): - with tempfile.NamedTemporaryFile() as f: + with tempfile.NamedTemporaryFile(mode='r') as f: self.settings.update_recent_files('foo.bee') self.settings.update_recent_files(f.name) self.settings.get_recent_files(existing_only=True) == [f.name] diff --git a/tests/test_utils.py b/tests/test_utils.py index 46965bc..1989fc7 100644 --- a/tests/test_utils.py +++ b/tests/test_utils.py @@ -1,3 +1,4 @@ +import logging import os.path import pytest import tempfile @@ -36,13 +37,14 @@ def test_round_to(number, base, expected): assert utils.round_to(number, base) == expected -class BeeRotatingFileHandler(BeeTestCase): +class BeeRotatingFileHandlerTestCase(BeeTestCase): def test_creates_new_dir(self): with tempfile.TemporaryDirectory() as tmpdir: logfile = os.path.join(tmpdir, 'foo', 'bar.log') handler = utils.BeeRotatingFileHandler(logfile) - handler.emit('foo') + handler.emit(logging.LogRecord( + 'foo', logging.INFO, 'bar', 66, 'baz', [], None)) handler.close() assert os.path.exists(logfile) @@ -50,6 +52,7 @@ class BeeRotatingFileHandler(BeeTestCase): with tempfile.TemporaryDirectory() as tmpdir: logfile = os.path.join(tmpdir, 'bar.log') handler = utils.BeeRotatingFileHandler(logfile) - handler.emit('foo') + handler.emit(logging.LogRecord( + 'foo', logging.INFO, 'bar', 66, 'baz', [], None)) handler.close() assert os.path.exists(logfile) diff --git a/tests/test_view.py b/tests/test_view.py index c4929db..5dd7f3c 100644 --- a/tests/test_view.py +++ b/tests/test_view.py @@ -286,7 +286,7 @@ class BeeGraphicsViewTestCase(ViewBaseTestCase): @patch('beeref.gui.DebugLogDialog.show') def test_on_action_debuglog(self, show_mock): - with tempfile.NamedTemporaryFile() as f: + with tempfile.NamedTemporaryFile(mode='r') as f: with patch('beeref.gui.logfile_name', return_value=f.name): self.view.on_action_debuglog() show_mock.assert_called_once()