From 53777bc346dcfcedb70eac2c434e711bb7c35b31 Mon Sep 17 00:00:00 2001 From: Rebecca Breu Date: Tue, 31 Aug 2021 19:08:34 +0200 Subject: [PATCH] Fix images getting loaded mirrored, fixes issue #20 This bug got introduced when adding test items. --- beeref/items.py | 2 +- tests/items/test_pixmapitem.py | 1 + tests/items/test_textitem.py | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/beeref/items.py b/beeref/items.py index 1857ff7..8b0173f 100644 --- a/beeref/items.py +++ b/beeref/items.py @@ -70,7 +70,7 @@ class BeeItemMixin(SelectableMixin): self.setZValue(kwargs.get('z', self.zValue())) self.setScale(kwargs.get('scale', self.scale())) self.setRotation(kwargs.get('rotation', self.rotation())) - if kwargs.get('flip') != self.flip(): + if kwargs.get('flip', 1) != self.flip(): self.do_flip() diff --git a/tests/items/test_pixmapitem.py b/tests/items/test_pixmapitem.py index 27f809e..25da944 100644 --- a/tests/items/test_pixmapitem.py +++ b/tests/items/test_pixmapitem.py @@ -149,6 +149,7 @@ def test_update_from_data_keeps_unset_values(item): item.setScale(3) item.update_from_data(rotation=45) assert item.scale() == 3 + assert item.flip() == 1 def test_create_from_data(item): diff --git a/tests/items/test_textitem.py b/tests/items/test_textitem.py index b2a5485..6e9bb06 100644 --- a/tests/items/test_textitem.py +++ b/tests/items/test_textitem.py @@ -181,6 +181,7 @@ def test_update_from_data_keeps_unset_values(qapp): item.setScale(3) item.update_from_data(rotation=45) assert item.scale() == 3 + assert item.flip() == 1 def test_create_from_data(qapp):