Rename add_delayed_items -> add_queued_items

This commit is contained in:
Rebecca Breu 2021-05-14 21:36:46 +02:00
parent d117790726
commit 33ed9d891f
3 changed files with 11 additions and 11 deletions

View file

@ -340,11 +340,11 @@ class BeeGraphicsScene(QtWidgets.QGraphicsScene):
self.itemsBoundingRect(selection_only=True))
def add_item_later(self, item, selected=False):
"""Keep an item for adding later via ``add_delayed_items``"""
"""Keep an item for adding later via ``add_queued_items``"""
self.items_to_add.put((item, selected))
def add_delayed_items(self):
def add_queued_items(self):
"""Adds items added via ``add_items_later``"""
while not self.items_to_add.empty():

View file

@ -255,7 +255,7 @@ class BeeGraphicsView(QtWidgets.QGraphicsView, ActionsMixin):
def on_items_loaded(self, value):
logger.debug('On items loded: add queued images')
self.scene.add_delayed_items()
self.scene.add_queued_items()
def on_loading_finished(self, filename, errors):
if filename:
@ -267,7 +267,7 @@ class BeeGraphicsView(QtWidgets.QGraphicsView, ActionsMixin):
('<p>Problem loading file %s</p>'
'<p>Not accessible or not a proper bee file</p>') % filename)
else:
self.scene.add_delayed_items()
self.scene.add_queued_items()
self.on_action_fit_scene()
def open_from_file(self, filename):
@ -362,7 +362,7 @@ class BeeGraphicsView(QtWidgets.QGraphicsView, ActionsMixin):
self,
'Problem loading images',
msg + errornames)
self.scene.add_delayed_items()
self.scene.add_queued_items()
self.scene.arrange_optimal()
self.undo_stack.endMacro()

View file

@ -806,25 +806,25 @@ class BeeGraphicsSceneTestCase(BeeTestCase):
self.scene.on_change(None)
self.scene.multi_select_item.fit_selection_area.assert_not_called()
def test_add_delayed_items_unselected(self):
def test_add_queued_items_unselected(self):
item = BeePixmapItem(QtGui.QImage())
item.setZValue(0.33)
self.scene.add_item_later(item, selected=False)
self.scene.add_delayed_items()
self.scene.add_queued_items()
assert self.scene.items() == [item]
assert item.isSelected() is False
assert self.scene.max_z == 0.33
def test_add_delayed_items_selected(self):
def test_add_queued_items_selected(self):
self.scene.max_z = 0.6
item = BeePixmapItem(QtGui.QImage())
item.setZValue(0.33)
self.scene.add_item_later(item, selected=True)
self.scene.add_delayed_items()
self.scene.add_queued_items()
assert self.scene.items() == [item]
assert item.isSelected() is True
assert item.zValue() > 0.6
def test_add_delayed_items_when_no_items(self):
self.scene.add_delayed_items()
def test_add_queued_items_when_no_items(self):
self.scene.add_queued_items()
assert self.scene.items() == []