tests: add more tests for hmac and X25519 encodings

internal/testkit/testkit.go

@@ -30,6 +30,16 @@ var _, TestX25519Identity, _ = bech32.Decode(
 
 var TestX25519Recipient, _ = curve25519.X25519(TestX25519Identity, curve25519.Basepoint)
 
+func NotCanonicalBase64(s string) string {
+	// Assuming there are spare zero bits at the end of the encoded bitstring,
+	// the character immediately after in the alphabet compared to the last one
+	// in the encoding will only flip the last bit to one, making the string a
+	// non-canonical encoding of the same value.
+	alphabet := "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/"
+	idx := strings.IndexByte(alphabet, s[len(s)-1])
+	return s[:len(s)-1] + string(alphabet[idx+1])
+}
+
 type TestFile struct {
 	Buf  bytes.Buffer
 	Rand func(n int) []byte
@@ -64,6 +74,14 @@ func (f *TestFile) TextLine(s string) {
 	f.Buf.WriteString("\n")
 }
 
+func (f *TestFile) UnreadLine() string {
+	buf := bytes.TrimSuffix(f.Buf.Bytes(), []byte("\n"))
+	idx := bytes.LastIndex(buf[:len(buf)-1], []byte("\n")) + 1
+	f.Buf.Reset()
+	f.Buf.Write(buf[:idx])
+	return string(buf[idx:])
+}
+
 func (f *TestFile) VersionLine(v string) {
 	f.TextLine("age-encryption.org/" + v)
 }

tests/crlf.go

@@ -0,0 +1,29 @@
+// Copyright 2022 The age Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build ignore
+
+package main
+
+import (
+	"bytes"
+
+	"filippo.io/age/internal/testkit"
+)
+
+func main() {
+	f := testkit.NewTestFile()
+	f.VersionLine("v1")
+	f.X25519(testkit.TestX25519Identity)
+	hdr := f.Buf.Bytes()
+	f.Buf.Reset()
+	f.Buf.Write(bytes.Replace(hdr, []byte("\n"), []byte("\r\n"), -1))
+	f.HMAC()
+	f.Buf.WriteString(f.UnreadLine())
+	f.Buf.WriteString("\r\n")
+	f.Payload("age")
+	f.ExpectHeaderFailure()
+	f.Comment("lines in the header end with CRLF instead of LF")
+	f.Generate()
+}

tests/hmac_bad.go

@@ -12,7 +12,7 @@ func main() {
 	f := testkit.NewTestFile()
 	f.VersionLine("v1")
 	f.X25519(testkit.TestX25519Identity)
-	f.FileKey(f.Rand(16))
+	f.FileKey(make([]byte, 16))
 	f.HMAC()
 	f.FileKey(testkit.TestFileKey)
 	f.Payload("age")

tests/hmac_extra_space.go

@@ -0,0 +1,24 @@
+// Copyright 2022 The age Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build ignore
+
+package main
+
+import (
+	"strings"
+
+	"filippo.io/age/internal/testkit"
+)
+
+func main() {
+	f := testkit.NewTestFile()
+	f.VersionLine("v1")
+	f.X25519(testkit.TestX25519Identity)
+	f.HMAC()
+	f.TextLine(strings.Replace(f.UnreadLine(), "--- ", "---  ", -1))
+	f.Payload("age")
+	f.ExpectHeaderFailure()
+	f.Generate()
+}

tests/hmac_garbage.go

@@ -0,0 +1,20 @@
+// Copyright 2022 The age Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build ignore
+
+package main
+
+import "filippo.io/age/internal/testkit"
+
+func main() {
+	f := testkit.NewTestFile()
+	f.VersionLine("v1")
+	f.X25519(testkit.TestX25519Identity)
+	f.HMAC()
+	f.TextLine(f.UnreadLine() + "AAA")
+	f.Payload("age")
+	f.ExpectHeaderFailure()
+	f.Generate()
+}

tests/hmac_missing.go

@@ -0,0 +1,19 @@
+// Copyright 2022 The age Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build ignore
+
+package main
+
+import "filippo.io/age/internal/testkit"
+
+func main() {
+	f := testkit.NewTestFile()
+	f.VersionLine("v1")
+	f.X25519(testkit.TestX25519Identity)
+	f.HMACLine(nil)
+	f.Payload("age")
+	f.ExpectHeaderFailure()
+	f.Generate()
+}

tests/hmac_no_space.go

@@ -0,0 +1,24 @@
+// Copyright 2022 The age Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build ignore
+
+package main
+
+import (
+	"strings"
+
+	"filippo.io/age/internal/testkit"
+)
+
+func main() {
+	f := testkit.NewTestFile()
+	f.VersionLine("v1")
+	f.X25519(testkit.TestX25519Identity)
+	f.HMAC()
+	f.TextLine(strings.Replace(f.UnreadLine(), "--- ", "---", -1))
+	f.Payload("age")
+	f.ExpectHeaderFailure()
+	f.Generate()
+}

tests/hmac_not_canonical.go

@@ -0,0 +1,21 @@
+// Copyright 2022 The age Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build ignore
+
+package main
+
+import "filippo.io/age/internal/testkit"
+
+func main() {
+	f := testkit.NewTestFile()
+	f.VersionLine("v1")
+	f.X25519(testkit.TestX25519Identity)
+	f.HMAC()
+	f.TextLine(testkit.NotCanonicalBase64(f.UnreadLine()))
+	f.Payload("age")
+	f.ExpectHeaderFailure()
+	f.Comment("the base64 encoding of the HMAC is not canonical")
+	f.Generate()
+}

tests/hmac_trailing_space.go

@@ -0,0 +1,20 @@
+// Copyright 2022 The age Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build ignore
+
+package main
+
+import "filippo.io/age/internal/testkit"
+
+func main() {
+	f := testkit.NewTestFile()
+	f.VersionLine("v1")
+	f.X25519(testkit.TestX25519Identity)
+	f.HMAC()
+	f.TextLine(f.UnreadLine() + " ")
+	f.Payload("age")
+	f.ExpectHeaderFailure()
+	f.Generate()
+}

tests/hmac_truncated.go

@@ -0,0 +1,20 @@
+// Copyright 2022 The age Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build ignore
+
+package main
+
+import "filippo.io/age/internal/testkit"
+
+func main() {
+	f := testkit.NewTestFile()
+	f.VersionLine("v1")
+	f.X25519(testkit.TestX25519Identity)
+	f.HMAC()
+	f.TextLine(f.UnreadLine()[:len("--- 1234")])
+	f.Payload("age")
+	f.ExpectHeaderFailure()
+	f.Generate()
+}

tests/x25519_extra_argument.go

@@ -0,0 +1,23 @@
+// Copyright 2022 The age Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build ignore
+
+package main
+
+import "filippo.io/age/internal/testkit"
+
+func main() {
+	f := testkit.NewTestFile()
+	f.VersionLine("v1")
+	f.X25519(testkit.TestX25519Recipient)
+	body, args := f.UnreadLine(), f.UnreadLine()
+	f.TextLine(args + " 1234")
+	f.TextLine(body)
+	f.HMAC()
+	f.Payload("age")
+	f.ExpectHeaderFailure()
+	f.Comment("the base64 encoding of the share is not canonical")
+	f.Generate()
+}

tests/x25519_low_order.go

@@ -33,6 +33,7 @@ func main() {
 	f.HMAC()
 	f.Payload("age")
 	f.ExpectHeaderFailure()
-	f.Comment("the X25519 share is a low-order point, so the shared secret is the disallowed all-zero value")
+	f.Comment("the X25519 share is a low-order point, so the shared secret" +
+		"is the disallowed all-zero value")
 	f.Generate()
 }

tests/x25519_not_canonical_body.go

@@ -0,0 +1,23 @@
+// Copyright 2022 The age Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build ignore
+
+package main
+
+import "filippo.io/age/internal/testkit"
+
+func main() {
+	f := testkit.NewTestFile()
+	f.VersionLine("v1")
+	f.X25519(testkit.TestX25519Recipient)
+	body, args := f.UnreadLine(), f.UnreadLine()
+	f.TextLine(args)
+	f.TextLine(testkit.NotCanonicalBase64(body))
+	f.HMAC()
+	f.Payload("age")
+	f.ExpectHeaderFailure()
+	f.Comment("the base64 encoding of the share is not canonical")
+	f.Generate()
+}

tests/x25519_not_canonical_share.go

@@ -0,0 +1,23 @@
+// Copyright 2022 The age Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build ignore
+
+package main
+
+import "filippo.io/age/internal/testkit"
+
+func main() {
+	f := testkit.NewTestFile()
+	f.VersionLine("v1")
+	f.X25519(testkit.TestX25519Recipient)
+	body, args := f.UnreadLine(), f.UnreadLine()
+	f.TextLine(testkit.NotCanonicalBase64(args))
+	f.TextLine(body)
+	f.HMAC()
+	f.Payload("age")
+	f.ExpectHeaderFailure()
+	f.Comment("the base64 encoding of the share is not canonical")
+	f.Generate()
+}