From f66e38291f311851caaa8613659dba1f1ce154f8 Mon Sep 17 00:00:00 2001
From: EnixCoda <enixcoda@gmail.com>
Date: Sun, 29 May 2022 23:27:13 +0800
Subject: [PATCH] feat: use primer checkbox

---
 src/components/SimpleToggleField.tsx | 92 +++++++++++++---------------
 src/utils/config/helper.ts           |  2 +
 2 files changed, 45 insertions(+), 49 deletions(-)

diff --git a/src/components/SimpleToggleField.tsx b/src/components/SimpleToggleField.tsx
index 529a584..e7e0773 100644
--- a/src/components/SimpleToggleField.tsx
+++ b/src/components/SimpleToggleField.tsx
@@ -1,14 +1,13 @@
+import { Checkbox, FormControl } from '@primer/react'
 import { useConfigs } from 'containers/ConfigsContext'
 import * as React from 'react'
-import { Config } from 'utils/config/helper'
-import { Field } from './settings/Field'
+import { Config, ConfigKeys } from 'utils/config/helper'
 
-export type SimpleField<Key extends keyof Config> = {
+export type SimpleField<Key extends ConfigKeys> = {
   key: Key
   label: string
   wikiLink?: string
   tooltip?: string
-  description?: string
   disabled?: boolean
   overwrite?: {
     value: (value: Config[Key]) => boolean
@@ -16,59 +15,54 @@ export type SimpleField<Key extends keyof Config> = {
   }
 }
 
-type Props<Key extends keyof Config> = {
+type Props<Key extends ConfigKeys> = {
   field: SimpleField<Key>
-
-  onChange?(): void
 }
 
-export function SimpleToggleField<Key extends keyof Config>({ field, onChange }: Props<Key>) {
+export function SimpleToggleField<Key extends ConfigKeys>({ field }: Props<Key>) {
   const { overwrite } = field
   const configContext = useConfigs()
   const value = configContext.value[field.key]
+
+  const checked = React.useMemo(
+    () => (overwrite ? overwrite.value(value) : Boolean(value)),
+    [overwrite, value],
+  )
+
+  const handleChange = React.useCallback(
+    (checked: boolean) => {
+      const enabled = checked
+      configContext.onChange({ [field.key]: overwrite ? overwrite.onChange(enabled) : enabled })
+    },
+    [field.key, overwrite, configContext],
+  )
+
   return (
-    <Field
-      id={field.key}
-      title={
-        <>
-          {field.label}{' '}
-          {field.wikiLink ? (
-            <a
-              href={field.wikiLink}
-              title={field.tooltip}
-              target="_blank"
-              rel="noopener noreferrer"
-            >
-              (?)
-            </a>
-          ) : field.description ? (
-            <p className={'note'} title={field.tooltip}>
-              {field.description}
-            </p>
-          ) : (
-            field.tooltip && (
-              <span className={'help'} title={field.tooltip}>
-                (?)
-              </span>
-            )
-          )}
-        </>
-      }
-      className={'field-checkbox'}
-      checkbox
-    >
-      <input
-        id={field.key}
-        name={field.key}
-        disabled={field.disabled}
-        type={'checkbox'}
-        onChange={async e => {
-          const enabled = e.currentTarget.checked
-          configContext.onChange({ [field.key]: overwrite ? overwrite.onChange(enabled) : enabled })
-          if (onChange) onChange()
+    <FormControl>
+      <Checkbox
+        sx={{
+          marginTop: '4px', // align label
         }}
-        checked={overwrite ? overwrite.value(value) : Boolean(value)}
+        value={field.key}
+        disabled={field.disabled}
+        onChange={e => handleChange(e.target.checked)}
+        checked={checked}
       />
-    </Field>
+      <FormControl.Label>
+        {field.label}
+        {(field.wikiLink || field.tooltip) && ' '}
+        {field.wikiLink ? (
+          <a href={field.wikiLink} title={field.tooltip} target="_blank" rel="noopener noreferrer">
+            (?)
+          </a>
+        ) : (
+          field.tooltip && (
+            <span className={'help'} title={field.tooltip}>
+              (?)
+            </span>
+          )
+        )}
+      </FormControl.Label>
+    </FormControl>
   )
 }
diff --git a/src/utils/config/helper.ts b/src/utils/config/helper.ts
index ac69b04..bd86a7d 100644
--- a/src/utils/config/helper.ts
+++ b/src/utils/config/helper.ts
@@ -21,6 +21,8 @@ export type Config = {
   restoreExpandedFolders: boolean
 }
 
+export type ConfigKeys = keyof Config
+
 enum configKeys {
   sideBarWidth = 'sideBarWidth',
   shortcut = 'shortcut',