refactor: safer config

src/driver/core/SideBar.ts

@@ -70,7 +70,7 @@ const init: MethodCreator<Props, ConnectorState> = dispatch => async () => {
       compressSingletonFolder,
       copyFileButton,
       copySnippetButton,
-    } = await configHelper.get()
+    } = await configHelper.getAll()
     DOMHelper.decorateGitHubPageContent({ copyFileButton, copySnippetButton })
     dispatch.set({
       accessToken,

src/utils/configHelper.ts

@@ -19,12 +19,12 @@ export enum config {
 
 const configKeys = Object.values(config)
 
-function get(): any {
+function getAll(): any {
   return storageHelper.get(configKeys) || {}
 }
 
 function getOne(key: keyof Config) {
-  return get()[key]
+  return getAll()[key]
 }
 
 function set(partialConfig: Partial<Config>) {
@@ -38,7 +38,7 @@ function setOne(key: config, value: any) {
 }
 
 export default {
-  get,
+  getAll,
   getOne,
   set,
   setOne,

src/utils/general.ts

@@ -2,10 +2,12 @@ export function pick<T>(source: T, keys: string[]): Partial<T> {
   if (keys && typeof keys === 'object') {
     return (Array.isArray(keys) ? keys : Object.keys(keys)).reduce(
       (copy, key) => {
-        copy[key as keyof T] = source[key as keyof T]
+        if (key in source) {
+          copy[key as keyof T] = source[key as keyof T]
+        }
         return copy
       },
-      {} as Partial<T>
+      {} as Partial<T>,
     )
   }
   return {} as Partial<T>