From c6fe580d338dce872b16f9a7689e3fbeb2647eed Mon Sep 17 00:00:00 2001
From: EnixCoda <enixcoda@gmail.com>
Date: Sat, 20 Aug 2022 21:22:05 +0800
Subject: [PATCH] chore: remove unnecessary useCallback

---
 src/components/SideBar.tsx                    |  9 +++---
 .../settings/AccessTokenSettings.tsx          | 28 ++++++-------------
 src/components/settings/SidebarSettings.tsx   |  4 +--
 3 files changed, 15 insertions(+), 26 deletions(-)

diff --git a/src/components/SideBar.tsx b/src/components/SideBar.tsx
index ff974f0..b3c87df 100644
--- a/src/components/SideBar.tsx
+++ b/src/components/SideBar.tsx
@@ -41,10 +41,6 @@ export function SideBar() {
 
   const blockLeaveRef = React.useRef(false)
   const { sidebarToggleMode } = configContext.value
-  const onMouseLeaveSideBar: React.MouseEventHandler<HTMLElement> = React.useCallback(() => {
-    if (blockLeaveRef.current) return
-    if (sidebarToggleMode === 'float') setShouldExpand(false)
-  }, [sidebarToggleMode, setShouldExpand])
   const onResizeStateChange = React.useCallback((state: ResizeState) => {
     blockLeaveRef.current = state === 'resizing'
   }, [])
@@ -79,7 +75,10 @@ export function SideBar() {
             collapsed: error || !shouldExpand,
           })}
           style={{ height: heightForSafari }}
-          onMouseLeave={onMouseLeaveSideBar}
+          onMouseLeave={() => {
+            if (blockLeaveRef.current) return
+            if (sidebarToggleMode === 'float') setShouldExpand(false)
+          }}
         >
           <div className={'gitako-side-bar-body'}>
             <div className={'gitako-side-bar-content'}>
diff --git a/src/components/settings/AccessTokenSettings.tsx b/src/components/settings/AccessTokenSettings.tsx
index d683eb3..50f55af 100644
--- a/src/components/settings/AccessTokenSettings.tsx
+++ b/src/components/settings/AccessTokenSettings.tsx
@@ -29,16 +29,6 @@ export function AccessTokenSettings() {
     setAccessTokenInputValue('')
   }, [accessToken])
 
-  const onInputAccessToken = React.useCallback(
-    ({ currentTarget: { value } }: React.FormEvent<HTMLInputElement>) => {
-      setAccessTokenInputValue(value)
-      useAccessTokenHint.onChange(
-        ACCESS_TOKEN_REGEXP.test(value) ? '' : 'Gitako does not recognize the token.',
-      )
-    },
-    [], // eslint-disable-line react-hooks/exhaustive-deps
-  )
-
   const saveToken = React.useCallback(
     async (
       hint: typeof useAccessTokenHint.value = (
@@ -59,13 +49,6 @@ export function AccessTokenSettings() {
     [accessTokenInputValue], // eslint-disable-line react-hooks/exhaustive-deps
   )
 
-  const onPressAccessToken = React.useCallback(
-    ({ key }: React.KeyboardEvent) => {
-      if (key === 'Enter') saveToken()
-    },
-    [saveToken],
-  )
-
   return (
     <SettingsSection
       title={
@@ -163,8 +146,15 @@ export function AccessTokenSettings() {
               placeholder="Or input here manually"
               onFocus={() => focusInput.onChange(true)}
               onBlur={() => focusInput.onChange(false)}
-              onChange={onInputAccessToken}
-              onKeyPress={onPressAccessToken}
+              onChange={({ currentTarget: { value } }) => {
+                setAccessTokenInputValue(value)
+                useAccessTokenHint.onChange(
+                  ACCESS_TOKEN_REGEXP.test(value) ? '' : 'Gitako does not recognize the token.',
+                )
+              }}
+              onKeyPress={({ key }) => {
+                if (key === 'Enter') saveToken()
+              }}
             />
             <Button onClick={() => saveToken()} disabled={!accessTokenInputValue}>
               Save
diff --git a/src/components/settings/SidebarSettings.tsx b/src/components/settings/SidebarSettings.tsx
index 588b08a..74e5328 100644
--- a/src/components/settings/SidebarSettings.tsx
+++ b/src/components/settings/SidebarSettings.tsx
@@ -56,13 +56,13 @@ function ToggleSidebarShortcutSettings() {
           placeholder={focused.value ? 'Press key combination' : 'Click here to set'}
           value={friendlyFormatShortcut(toggleShowSideBarShortcut)}
           onChange={noop}
-          onKeyDown={React.useCallback((e: React.KeyboardEvent<HTMLInputElement>) => {
+          onKeyDown={e => {
             e.preventDefault()
             e.stopPropagation()
             // Clear shortcut with backspace
             const shortcut = e.key === 'Backspace' ? '' : keyHelper.parseEvent(e)
             useToggleShowSideBarShortcut.onChange(shortcut)
-          }, [])} // eslint-disable-line react-hooks/exhaustive-deps
+          }}
         />
         {shortcut === toggleShowSideBarShortcut ? (
           <Button