From a42750ff5e8c8a044b283081b1589f709a1fe500 Mon Sep 17 00:00:00 2001 From: EnixCoda Date: Wed, 8 Apr 2020 17:37:25 +0800 Subject: [PATCH] fix: prevent inserting duplicated mount points --- src/utils/DOMHelper.ts | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/utils/DOMHelper.ts b/src/utils/DOMHelper.ts index 442d6e1..5671d80 100644 --- a/src/utils/DOMHelper.ts +++ b/src/utils/DOMHelper.ts @@ -48,15 +48,14 @@ export function $ any, O extends * add the logo element into DOM */ export function insertLogoMountPoint() { - const logoSelector = '.gitako .gitako-logo' - return $(logoSelector) || createLogoMountPoint() -} - -function createLogoMountPoint() { - const logoMountElement = document.createElement('div') - logoMountElement.classList.add('gitako-logo-mount-point') - document.body.appendChild(logoMountElement) - return logoMountElement + const logoID = 'gitako-logo-mount-point' + const logoSelector = '#' + logoID + return $(logoSelector, undefined, function createLogoMountPoint() { + const logoMountElement = document.createElement('div') + logoMountElement.setAttribute('id', logoID) + document.body.appendChild(logoMountElement) + return logoMountElement + }) } /**