From 5156e6b9704f5f1c58003d45ea5f3456adbefbbe Mon Sep 17 00:00:00 2001 From: EnixCoda Date: Wed, 1 Apr 2020 23:57:03 +0800 Subject: [PATCH] fix: cancel copy file button effect properly --- src/platforms/GitHub/DOMHelper.ts | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/platforms/GitHub/DOMHelper.ts b/src/platforms/GitHub/DOMHelper.ts index c53c4da..b1ffde8 100644 --- a/src/platforms/GitHub/DOMHelper.ts +++ b/src/platforms/GitHub/DOMHelper.ts @@ -127,12 +127,14 @@ export function attachCopyFileBtn() { buttonGroup.appendChild(button) } }) - return () => { - const buttons = document.querySelectorAll(`.${copyFileButtonClassName}`) - buttons.forEach(button => { - button.parentElement?.removeChild(button) - }) - } + } + + // return callback so that disabling after redirecting from file page to non-page works properly + return () => { + const buttons = document.querySelectorAll(`.${copyFileButtonClassName}`) + buttons.forEach(button => { + button.parentElement?.removeChild(button) + }) } }