From 26d0b189bc731ea21d55a3b611039eee87304acc Mon Sep 17 00:00:00 2001 From: EnixCoda Date: Wed, 13 Nov 2019 16:23:23 +0800 Subject: [PATCH] fix: resolve return value for effects --- src/components/SideBar.tsx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/components/SideBar.tsx b/src/components/SideBar.tsx index 8ff4539..08a0a21 100644 --- a/src/components/SideBar.tsx +++ b/src/components/SideBar.tsx @@ -72,15 +72,17 @@ const RawGitako: React.FC = function RawGitako(props) { }, [props.metaData, configContext.val.intelligentToggle]) React.useEffect(() => { - if (configContext.val.copyFileButton) return DOMHelper.attachCopyFileBtn() + if (configContext.val.copyFileButton) return DOMHelper.attachCopyFileBtn() || undefined // undefined is friendlier to React }, [configContext.val.copyFileButton]) React.useEffect(() => { - if (configContext.val.copySnippetButton) return DOMHelper.attachCopySnippet() + if (configContext.val.copySnippetButton) return DOMHelper.attachCopySnippet() || undefined // undefined is friendlier to React }, [configContext.val.copySnippetButton]) // init again when setting new accessToken - useDidUpdate(() => props.init(), [accessToken]) + useDidUpdate(() => { + props.init() + }, [accessToken]) const { errorDueToAuth,