prehistoric-systems/Gitako
1
1
Fork 0
mirror of https://github.com/EnixCoda/Gitako.git synced 2026-03-11 08:54:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor: memoize regexp of search key

Browse source
This commit is contained in:
EnixCoda 2020-10-26 19:01:05 +08:00
parent d683777c34
commit 24ae8a0353
No known key found for this signature in database
GPG key ID: 0C1A07377913A1DD
1 changed files with 24 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
src/components/FileExplorer.tsx
View file

@ -132,9 +132,7 @@ const VirtualNode = React.memo(function VirtualNode({
style,
data,
}: ListChildComponentProps) {
const { searchKey, onNodeClick, renderActions, visibleNodes } = data
const regex =
searchKey && isValidRegexpSource(searchKey) ? new RegExp(searchKey, 'gi') : undefined
const { regex, onNodeClick, renderActions, visibleNodes } = data
if (!visibleNodes) return null
const { nodes, focusedNode, expandedNodes, loading, depths } = visibleNodes as VisibleNodes
@ -155,6 +153,15 @@ const VirtualNode = React.memo(function VirtualNode({
)
})
type ListViewProps = {
height: number
width: number
searchKey: string
onNodeClick(event: React.MouseEvent<HTMLElement, MouseEvent>, node: TreeNode): void
renderActions?(node: TreeNode): React.ReactNode
visibleNodes: VisibleNodes
}
function ListView({
width,
height,
@ -164,15 +171,7 @@ function ListView({
onNodeClick,
renderActions,
visibleNodes,
}: {
height: number
width: number
searchKey: string
onNodeClick(event: React.MouseEvent<HTMLElement, MouseEvent>, node: TreeNode): void
renderActions?(node: TreeNode): React.ReactNode
visibleNodes: VisibleNodes
} & Pick<Props, 'metaData'> &
Pick<ConnectorState, 'expandTo'>) {
}: ListViewProps & Pick<Props, 'metaData'> & Pick<ConnectorState, 'expandTo'>) {
const listRef = React.useRef<FixedSizeList>(null)
const { focusedNode, nodes } = visibleNodes
React.useEffect(() => {
@ -188,13 +187,25 @@ function ListView({
const targetPath = platform.getCurrentPath(metaData.branchName)
if (targetPath) expandTo(targetPath)
}, [metaData.branchName])
useOnLocationChange(goToCurrentItem)
useEvent('pjax:ready', goToCurrentItem, document)
const itemData = React.useMemo(
() => ({
regex: searchKey && isValidRegexpSource(searchKey) ? new RegExp(searchKey, 'gi') : undefined,
onNodeClick,
renderActions,
visibleNodes,
}),
[searchKey, onNodeClick, renderActions, visibleNodes],
)
return (
<FixedSizeList
ref={listRef}
itemKey={(index, { visibleNodes }) => visibleNodes?.nodes[index]?.path}
itemData={{ searchKey, onNodeClick, renderActions, visibleNodes }}
itemData={itemData}
itemCount={nodes.length}
itemSize={36}
height={height}