From 1588a903c216a166f9bdb2cb75323d8050087320 Mon Sep 17 00:00:00 2001 From: EnixCoda Date: Sat, 6 Feb 2021 01:23:13 +0800 Subject: [PATCH] refactor: drop shrink GitHub header --- src/components/SideBar.tsx | 21 +-------------------- src/components/settings/SettingsBar.tsx | 4 ---- src/utils/configHelper.ts | 3 --- 3 files changed, 1 insertion(+), 27 deletions(-) diff --git a/src/components/SideBar.tsx b/src/components/SideBar.tsx index 1c9707e..b9b1115 100644 --- a/src/components/SideBar.tsx +++ b/src/components/SideBar.tsx @@ -9,11 +9,7 @@ import { connect } from 'driver/connect' import { SideBarCore } from 'driver/core' import { ConnectorState, Props } from 'driver/core/SideBar' import { platform } from 'platforms' -import { - GitHub, - useGitHubAttachCopyFileButton, - useGitHubAttachCopySnippetButton, -} from 'platforms/GitHub' +import { useGitHubAttachCopyFileButton, useGitHubAttachCopySnippetButton } from 'platforms/GitHub' import * as React from 'react' import { cx } from 'utils/cx' import { parseURLSearch, run } from 'utils/general' @@ -42,8 +38,6 @@ const RawGitako: React.FC = function RawGitako(props) { const accessToken = configContext.value.accessToken || '' const [baseSize] = React.useState(() => configContext.value.sideBarWidth) - useShrinkGitHubHeader(configContext.value.shrinkGitHubHeader) - React.useEffect(() => { run(async function () { if (!accessToken) { @@ -156,19 +150,6 @@ RawGitako.defaultProps = { export const SideBar = connect(SideBarCore)(RawGitako) -function useShrinkGitHubHeader(shrinkGitHubHeader: boolean) { - React.useEffect(() => { - if (platform === GitHub) { - const target = document.body - if (shrinkGitHubHeader) { - target.classList.add('shrink-github-header') - } else { - target.classList.remove('shrink-github-header') - } - } - }, [shrinkGitHubHeader]) -} - async function trySetUpAccessTokenWithCode() { const search = parseURLSearch() if ('code' in search) { diff --git a/src/components/settings/SettingsBar.tsx b/src/components/settings/SettingsBar.tsx index bd6bc5e..70b579e 100644 --- a/src/components/settings/SettingsBar.tsx +++ b/src/components/settings/SettingsBar.tsx @@ -45,10 +45,6 @@ function SettingsBarContent() { wikiLink: wikiLinks.copySnippet, tooltip: `Read more in Gitako's Wiki`, }, - { - key: 'shrinkGitHubHeader', - label: 'Shrink GitHub header(experimental)', - }, ] : [] diff --git a/src/utils/configHelper.ts b/src/utils/configHelper.ts index 257b829..68ddd08 100644 --- a/src/utils/configHelper.ts +++ b/src/utils/configHelper.ts @@ -13,7 +13,6 @@ export type Config = { toggleButtonVerticalDistance: number toggleButtonContent: 'logo' | 'octoface' recursiveToggleFolder: 'shift' | 'alt' - shrinkGitHubHeader: boolean searchMode: SearchMode } @@ -29,7 +28,6 @@ enum configKeys { toggleButtonVerticalDistance = 'toggleButtonVerticalDistance', toggleButtonContent = 'toggleButtonContent', recursiveToggleFolder = 'recursiveToggleFolder', - shrinkGitHubHeader = 'shrinkGitHubHeader', searchMode = 'searchMode', } @@ -45,7 +43,6 @@ const defaultConfigs: Config = { toggleButtonVerticalDistance: 124, // align with GitHub's navbar items toggleButtonContent: 'logo', recursiveToggleFolder: 'shift', - shrinkGitHubHeader: false, searchMode: 'fuzzy', }