prehistoric-systems/Gitako
1
1
Fork 0
mirror of https://github.com/EnixCoda/Gitako.git synced 2026-03-11 08:54:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: handle path with unsafe trunks

Browse source
This commit is contained in:
EnixCoda 2020-11-11 17:42:42 +08:00
parent c057fb389f
commit 0c0ee18795
No known key found for this signature in database
GPG key ID: 0C1A07377913A1DD
1 changed files with 18 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/platforms/GitHub/index.ts
View file

@ -68,7 +68,15 @@ function getUrlForRedirect(
type = 'blob',
path = '',
) {
return `https://${window.location.host}/${userName}/${repoName}/${type}/${branchName}/${path}`
// Modern browsers have great support for handling unsafe URL,
// It may be possible to sanitize path with
// `path => path.includes('#') ? path.replace(/#/g, '%23') : '...'
return `https://${
window.location.host
}/${userName}/${repoName}/${type}/${branchName}/${path
.split('/')
.map(encodeURIComponent)
.join('/')}`
}
export function isEnterprise() {
@ -142,18 +150,15 @@ export const GitHub: Platform = {
const creator = await createPullFileResolver(userName, repoName, pullId)
const nodes: TreeNode[] = treeData.map(item => {
const id = creator(item.filename)
return {
path: item.filename || '',
type: 'blob',
name: item.filename?.replace(/^.*\//, '') || '',
url: `https://${window.location.host}/${metaData.userName}/${
metaData.repoName
}/pull/${pullId}/files${window.location.search}#${id || ''}`,
sha: item.sha,
}
})
const nodes: TreeNode[] = treeData.map(item => ({
path: item.filename || '',
type: 'blob',
name: item.filename?.replace(/^.*\//, '') || '',
url: `https://${window.location.host}/${metaData.userName}/${
metaData.repoName
}/pull/${pullId}/files${window.location.search}#${creator(item.filename) || ''}`,
sha: item.sha,
}))
const root = processTree(nodes)
return { root }