mirror of
https://github.com/Flow-Launcher/Flow.Launcher.git
synced 2026-03-11 08:54:32 +00:00
Added `lockAcquired` flags in `PluginsManifest.cs` and `Main.cs` to ensure semaphore locks are only released if successfully acquired, preventing potential runtime errors. Updated `finally` blocks to conditionally release locks based on these flags. Removed redundant cancellation check in `EverythingAPI.cs` to simplify code, assuming cancellation is handled elsewhere. These changes enhance reliability and maintainability of the codebase.
99 lines
3.9 KiB
C#
99 lines
3.9 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Flow.Launcher.Plugin;
|
|
using Flow.Launcher.Infrastructure;
|
|
|
|
namespace Flow.Launcher.Core.ExternalPlugins
|
|
{
|
|
public static class PluginsManifest
|
|
{
|
|
private static readonly string ClassName = nameof(PluginsManifest);
|
|
|
|
private static readonly CommunityPluginStore mainPluginStore =
|
|
new("https://raw.githubusercontent.com/Flow-Launcher/Flow.Launcher.PluginsManifest/main/plugins.json",
|
|
"https://fastly.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@main/plugins.json",
|
|
"https://gcore.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@main/plugins.json",
|
|
"https://cdn.jsdelivr.net/gh/Flow-Launcher/Flow.Launcher.PluginsManifest@main/plugins.json");
|
|
|
|
private static readonly SemaphoreSlim manifestUpdateLock = new(1);
|
|
|
|
private static DateTime lastFetchedAt = DateTime.MinValue;
|
|
private static readonly TimeSpan fetchTimeout = TimeSpan.FromMinutes(2);
|
|
|
|
public static List<UserPlugin> UserPlugins { get; private set; }
|
|
|
|
public static async Task<bool> UpdateManifestAsync(bool usePrimaryUrlOnly = false, CancellationToken token = default)
|
|
{
|
|
bool lockAcquired = false;
|
|
try
|
|
{
|
|
await manifestUpdateLock.WaitAsync(token).ConfigureAwait(false);
|
|
lockAcquired = true;
|
|
|
|
if (UserPlugins == null || usePrimaryUrlOnly || DateTime.Now.Subtract(lastFetchedAt) >= fetchTimeout)
|
|
{
|
|
var results = await mainPluginStore.FetchAsync(token, usePrimaryUrlOnly).ConfigureAwait(false);
|
|
|
|
// If the results are empty, we shouldn't update the manifest because the results are invalid.
|
|
if (results.Count == 0)
|
|
return false;
|
|
|
|
var updatedPluginResults = new List<UserPlugin>();
|
|
var appVersion = SemanticVersioning.Version.Parse(Constant.Version);
|
|
|
|
for (int i = 0; i < results.Count; i++)
|
|
{
|
|
if (IsMinimumAppVersionSatisfied(results[i], appVersion))
|
|
updatedPluginResults.Add(results[i]);
|
|
}
|
|
|
|
UserPlugins = updatedPluginResults;
|
|
|
|
lastFetchedAt = DateTime.Now;
|
|
|
|
return true;
|
|
}
|
|
}
|
|
catch (OperationCanceledException)
|
|
{
|
|
// Ignored
|
|
}
|
|
catch (Exception e)
|
|
{
|
|
PublicApi.Instance.LogException(ClassName, "Http request failed", e);
|
|
}
|
|
finally
|
|
{
|
|
// Only release the lock if it was acquired
|
|
if (lockAcquired) manifestUpdateLock.Release();
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
private static bool IsMinimumAppVersionSatisfied(UserPlugin plugin, SemanticVersioning.Version appVersion)
|
|
{
|
|
if (string.IsNullOrEmpty(plugin.MinimumAppVersion))
|
|
return true;
|
|
|
|
try
|
|
{
|
|
if (appVersion >= SemanticVersioning.Version.Parse(plugin.MinimumAppVersion))
|
|
return true;
|
|
}
|
|
catch (Exception e)
|
|
{
|
|
PublicApi.Instance.LogException(ClassName, $"Failed to parse the minimum app version {plugin.MinimumAppVersion} for plugin {plugin.Name}. "
|
|
+ "Plugin excluded from manifest", e);
|
|
return false;
|
|
}
|
|
|
|
PublicApi.Instance.LogInfo(ClassName, $"Plugin {plugin.Name} requires minimum Flow Launcher version {plugin.MinimumAppVersion}, "
|
|
+ $"but current version is {Constant.Version}. Plugin excluded from manifest.");
|
|
|
|
return false;
|
|
}
|
|
}
|
|
}
|