Every time I start Flow Launcher since the plugins refactor, the Bookmarks plugin has been throwing an exception. The issue stems from it parsing the Bookmarks file, and assuming that every JsonElement in the "roots" element is a JsonValueKind.Object. My Bookmarks file though has a JsonValueKind.String value off the roots key of `"sync_transaction_version": "20297",` along-side the bookmark_bar, other, and synced keys, which ARE objects. When it hits that sync_transaction_version string, and calls EnumerateFolderBookmark with it, it gets into the method because it IS a JsonElement, but then throws an exception on the folderElement.TryGetProperty("children", ...) call because you can't call TryGetProperty on a String, only Objects.
## Bug fixes
- Addresses the issue where WindowsSettings plugin results appear higher than other results #1020
- Fixed an issue where full screen mode does not disable hotkey when enabled #1037
- Fixed some potential issues when loading plugins that use shared assembly #1036
- Sorted out a race condition issue causing image loading on some results to fail #1040
- Revised ttf/otf support #935
- Resolved the issue where WebSearch plugin would crash if not connected to internet #977
- Fixed incorrect text for "New Tab" and "New Window" buttons under Settings' default browser section #951
- Fixed typos in plugin title and WindowsSettings name inside the context menu #1056
Merging 1.9.2 back into dev. Following commits already exist in dev:
* Bump SharpZipLib in /Plugins/Flow.Launcher.Plugin.PluginsManager
Bumps [SharpZipLib](https://github.com/icsharpcode/SharpZipLib) from 1.3.2 to 1.3.3.
- [Release notes](https://github.com/icsharpcode/SharpZipLib/releases)
- [Changelog](https://github.com/icsharpcode/SharpZipLib/blob/master/docs/Changes.txt)
- [Commits](https://github.com/icsharpcode/SharpZipLib/compare/v1.3.2...v1.3.3)
---
updated-dependencies:
- dependency-name: SharpZipLib
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
* version bump PluginsManager
* Fix spellings in translation keys
* Clean up deprecated translations
* Some pedantic capitalisation
* bump WebSearch plugin
* use resources for raising top most success message
* Use Microsoft Package to register toast notification
* stop trigger global hotkey when shell plugin is not enabled
* Shell plugin version bump
* - Change Toggle Switch Flow (LTR from RTL)
- Change Open Theme Folder Button Width to Responsive
* - Adjust Priority Button Position
* - Adjust Priority Button Margin
* version bump
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: tech189 <dlloyd189@gmail.com>
Co-authored-by: Hongtao Zhang <hongtao_zhang@outlook.com>
Co-authored-by: DB p <onesound@oooz.net>
