From f93dcaef73a9478d0c5920c9eca41ff2e91ff3a4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=BC=98=E9=9F=AC=20=E5=BC=A0?= Date: Tue, 9 Feb 2021 14:03:22 +0800 Subject: [PATCH] use throw instead of return empty string --- Flow.Launcher.Core/Plugin/JsonRPCPlugin.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Flow.Launcher.Core/Plugin/JsonRPCPlugin.cs b/Flow.Launcher.Core/Plugin/JsonRPCPlugin.cs index 7d221b74d..5b56f9347 100644 --- a/Flow.Launcher.Core/Plugin/JsonRPCPlugin.cs +++ b/Flow.Launcher.Core/Plugin/JsonRPCPlugin.cs @@ -185,14 +185,18 @@ namespace Flow.Launcher.Core.Plugin } using var standardOutput = process.StandardOutput; + + token.ThrowIfCancellationRequested(); + var result = await standardOutput.ReadToEndAsync(); - if (token.IsCancellationRequested) - return string.Empty; + token.ThrowIfCancellationRequested(); if (string.IsNullOrEmpty(result)) { using var standardError = process.StandardError; var error = await standardError.ReadToEndAsync(); + token.ThrowIfCancellationRequested(); + if (!string.IsNullOrEmpty(error)) { Log.Error($"|JsonRPCPlugin.ExecuteAsync|{error}");