prehistoric-systems/Flow.Launcher
1
0
Fork 0
mirror of https://github.com/Flow-Launcher/Flow.Launcher.git synced 2026-03-11 08:54:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Resolved: TabsTracker is not disposed - potential resource leak.

Browse source
This commit is contained in:
Andrzej Martyna 2025-12-28 23:46:38 +01:00
parent 382dd791ff
commit ecfe8c302d
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Plugins/Flow.Launcher.Plugin.BrowserBookmark/Main.cs
View file

@ -28,7 +28,7 @@ public class Main : ISettingProvider, IPlugin, IReloadable, IPluginI18n, IContex
private static bool _initialized = false;
private readonly TabsTracker tabsTracker = new();
private readonly TabsTracker _tabsTracker = new();
public void Init(PluginInitContext context)
{
@ -62,7 +62,7 @@ public class Main : ISettingProvider, IPlugin, IReloadable, IPluginI18n, IContex
LoadBookmarksIfEnabled();
tabsTracker.Init();
_tabsTracker.Init();
}
private static void LoadBookmarksIfEnabled()
@ -97,7 +97,7 @@ public class Main : ISettingProvider, IPlugin, IReloadable, IPluginI18n, IContex
if (!topResults)
{
// Since we mixed chrome and firefox bookmarks, we should order them again
return tabsTracker.InjectExistingTabs(_settings, _cachedBookmarks
return _tabsTracker.InjectExistingTabs(_settings, _cachedBookmarks
.Select(
c => new Result
{
@ -109,7 +109,7 @@ public class Main : ISettingProvider, IPlugin, IReloadable, IPluginI18n, IContex
Score = BookmarkLoader.MatchProgram(c, param).Score,
Action = _ =>
{
tabsTracker.OpenUrlAndTrack(_settings, c.Url);
_tabsTracker.OpenUrlAndTrack(_settings, c.Url);
return true;
},
ContextData = new BookmarkAttributes { Url = c.Url }
@ -120,7 +120,7 @@ public class Main : ISettingProvider, IPlugin, IReloadable, IPluginI18n, IContex
}
else
{
return tabsTracker.InjectExistingTabs(_settings, _cachedBookmarks
return _tabsTracker.InjectExistingTabs(_settings, _cachedBookmarks
.Select(
c => new Result
{
@ -132,7 +132,7 @@ public class Main : ISettingProvider, IPlugin, IReloadable, IPluginI18n, IContex
Score = 5,
Action = _ =>
{
tabsTracker.OpenUrlAndTrack(_settings, c.Url);
_tabsTracker.OpenUrlAndTrack(_settings, c.Url);
return true;
},
ContextData = new BookmarkAttributes { Url = c.Url }
@ -265,6 +265,7 @@ public class Main : ISettingProvider, IPlugin, IReloadable, IPluginI18n, IContex
public void Dispose()
{
_tabsTracker?.Dispose();
DisposeFileWatchers();
}