prehistoric-systems/Flow.Launcher
1
0
Fork 0
mirror of https://github.com/Flow-Launcher/Flow.Launcher.git synced 2026-03-11 08:54:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Refactor plugin min version check and improve logging

Browse source 
Refactored the plugin minimum app version check to use Version.TryParse instead of try-catch with Version.Parse, preventing exceptions on invalid input. Improved error handling by logging parse failures as errors and version mismatches as info, making the logic clearer and more robust.
This commit is contained in:
Jack251970 2026-02-27 18:48:59 +08:00
parent b1b18ee215
commit b02a5a265d
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
Flow.Launcher.Core/Plugin/PluginManager.cs
View file

@ -1082,17 +1082,16 @@ namespace Flow.Launcher.Core.Plugin
var appVersion = Version.Parse(Constant.Version);
try
if (!Version.TryParse(minimumAppVersion, out var minimumVersion))
{
if (appVersion >= Version.Parse(minimumAppVersion))
PublicApi.Instance.LogError(ClassName,
$"Failed to parse the minimum app version {minimumAppVersion} for plugin {pluginName}. "
+ "Plugin excluded from manifest");
return false; // If the minimum app version specified in plugin.json is invalid, we assume it is not satisfied
}
if (appVersion >= minimumVersion)
return true;
}
catch (Exception e)
{
PublicApi.Instance.LogException(ClassName, $"Failed to parse the minimum app version {minimumAppVersion} for plugin {pluginName}. "
+ "Plugin excluded from manifest", e);
return false;
}
PublicApi.Instance.LogInfo(ClassName, $"Plugin {pluginName} requires minimum Flow Launcher version {minimumAppVersion}, "
+ $"but current version is {Constant.Version}. Plugin excluded from manifest.");