Merge pull request #3943 from Flow-Launcher/update_manifest_url_fetch

Handle MinimumAppVersion parse fail and reorder last manifest fetch date
This commit is contained in:
Jeremy Wu 2025-09-04 23:14:38 +10:00 committed by GitHub
commit 738a27e9b6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -43,8 +43,6 @@ namespace Flow.Launcher.Core.ExternalPlugins
if (results.Count == 0)
return false;
lastFetchedAt = DateTime.Now;
var updatedPluginResults = new List<UserPlugin>();
var appVersion = SemanticVersioning.Version.Parse(Constant.Version);
@ -56,6 +54,8 @@ namespace Flow.Launcher.Core.ExternalPlugins
UserPlugins = updatedPluginResults;
lastFetchedAt = DateTime.Now;
return true;
}
}
@ -73,10 +73,22 @@ namespace Flow.Launcher.Core.ExternalPlugins
private static bool IsMinimumAppVersionSatisfied(UserPlugin plugin, SemanticVersioning.Version appVersion)
{
if (string.IsNullOrEmpty(plugin.MinimumAppVersion) || appVersion >= SemanticVersioning.Version.Parse(plugin.MinimumAppVersion))
if (string.IsNullOrEmpty(plugin.MinimumAppVersion))
return true;
API.LogDebug(ClassName, $"Plugin {plugin.Name} requires minimum Flow Launcher version {plugin.MinimumAppVersion}, "
try
{
if (appVersion >= SemanticVersioning.Version.Parse(plugin.MinimumAppVersion))
return true;
}
catch (Exception e)
{
API.LogException(ClassName, $"Failed to parse the minimum app version {plugin.MinimumAppVersion} for plugin {plugin.Name}. "
+ "Plugin excluded from manifest", e);
return false;
}
API.LogInfo(ClassName, $"Plugin {plugin.Name} requires minimum Flow Launcher version {plugin.MinimumAppVersion}, "
+ $"but current version is {Constant.Version}. Plugin excluded from manifest.");
return false;