From 1f45c02bf1762d602f9d25b3737a8b742950eacc Mon Sep 17 00:00:00 2001 From: Andrzej Martyna Date: Mon, 29 Dec 2025 09:38:18 +0100 Subject: [PATCH] Added TODO.md for ideas to improve --- Plugins/Flow.Launcher.Plugin.BrowserBookmark/Tabs/TODO.md | 8 ++++++++ .../Tabs/TabsWalker.cs | 1 - 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 Plugins/Flow.Launcher.Plugin.BrowserBookmark/Tabs/TODO.md diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Tabs/TODO.md b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Tabs/TODO.md new file mode 100644 index 000000000..554483a50 --- /dev/null +++ b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Tabs/TODO.md @@ -0,0 +1,8 @@ +# Items to consider to improve the code + +- TabsWalker.GetCurrentTabFromWindow + - Research browsers' settings and check if it may break current assumption of just taking the last tab + +- absTracker + - AutomationFocusChangedEventHandler could be replaced with AutomationStructureChangedEventHandler, StructureChangeType.ChildAdded + - Removal of tabs should be handled to save memory by using AutomationStructureChangedEventHandler, StructureChangeType.ChildRemoved diff --git a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Tabs/TabsWalker.cs b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Tabs/TabsWalker.cs index d4393d934..04b780be4 100644 --- a/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Tabs/TabsWalker.cs +++ b/Plugins/Flow.Launcher.Plugin.BrowserBookmark/Tabs/TabsWalker.cs @@ -79,7 +79,6 @@ internal class TabsWalker // Let's take the last one and assume this is the one that was created recently // This is the best known approach as of today // There might be some browsers' settings that change this behavior but weren't tested nor considered yet - //TODO: research browsers' settings and check if it may break current assumption of just taking the last tab return InitiateTab(process, tabs.Last()); }