From 05fd41a1047b47e626cfbeef4ef95e7d27c93095 Mon Sep 17 00:00:00 2001
From: Kevin Zhang <hongtao_zhang@outlook.com>
Date: Wed, 8 Dec 2021 10:38:37 -0600
Subject: [PATCH] fix new tab not save issue

---
 .../UserSettings/CustomBrowserViewModel.cs           |  1 +
 Flow.Launcher/SelectBrowserWindow.xaml               |  6 +++---
 Flow.Launcher/SelectBrowserWindow.xaml.cs            | 12 ++++++------
 3 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/Flow.Launcher.Infrastructure/UserSettings/CustomBrowserViewModel.cs b/Flow.Launcher.Infrastructure/UserSettings/CustomBrowserViewModel.cs
index 30b7c5a68..83d5b14c9 100644
--- a/Flow.Launcher.Infrastructure/UserSettings/CustomBrowserViewModel.cs
+++ b/Flow.Launcher.Infrastructure/UserSettings/CustomBrowserViewModel.cs
@@ -18,6 +18,7 @@ namespace Flow.Launcher.Infrastructure.UserSettings
             {
                 Name = Name,
                 Path = Path,
+                OpenInTab = OpenInTab,
                 PrivateArg = PrivateArg,
                 EnablePrivate = EnablePrivate,
                 Editable = Editable
diff --git a/Flow.Launcher/SelectBrowserWindow.xaml b/Flow.Launcher/SelectBrowserWindow.xaml
index 85083fa50..594a4325d 100644
--- a/Flow.Launcher/SelectBrowserWindow.xaml
+++ b/Flow.Launcher/SelectBrowserWindow.xaml
@@ -107,7 +107,7 @@
                         Margin="10,0,0,0"
                         Click="btnDelete_Click"
                         Content="{DynamicResource delete}"
-                        IsEnabled="{Binding CustomExplorer.Editable}" />
+                        IsEnabled="{Binding CustomBrowser.Editable}" />
 
                 </StackPanel>
                 <Rectangle
@@ -117,7 +117,7 @@
                 <StackPanel
                     Margin="0,0,0,0"
                     HorizontalAlignment="Stretch"
-                    DataContext="{Binding CustomExplorer}"
+                    DataContext="{Binding CustomBrowser}"
                     Orientation="Horizontal">
                     <Grid Width="480">
                         <Grid.ColumnDefinitions>
@@ -197,7 +197,7 @@
                             VerticalAlignment="Center"
                             Orientation="Horizontal">
                             <RadioButton GroupName="browser" IsChecked="{Binding OpenInTab}">New Tab</RadioButton>
-                            <RadioButton GroupName="browser" IsChecked="{Binding OpenInNewWindow, Mode=OneWay}">New Window</RadioButton>
+                            <RadioButton GroupName="browser" IsChecked="{Binding OpenInNewWindow, Mode=OneTime}">New Window</RadioButton>
                         </StackPanel>
                         <TextBlock
                             Grid.Row="3"
diff --git a/Flow.Launcher/SelectBrowserWindow.xaml.cs b/Flow.Launcher/SelectBrowserWindow.xaml.cs
index 5ab888527..9013d2756 100644
--- a/Flow.Launcher/SelectBrowserWindow.xaml.cs
+++ b/Flow.Launcher/SelectBrowserWindow.xaml.cs
@@ -20,7 +20,7 @@ namespace Flow.Launcher
 {
     public partial class SelectBrowserWindow : Window, INotifyPropertyChanged
     {
-        private int selectedCustomExplorerIndex;
+        private int selectedCustomBrowserIndex;
 
         public event PropertyChangedEventHandler PropertyChanged;
 
@@ -28,15 +28,15 @@ namespace Flow.Launcher
 
         public int SelectedCustomBrowserIndex
         {
-            get => selectedCustomExplorerIndex; set
+            get => selectedCustomBrowserIndex; set
             {
-                selectedCustomExplorerIndex = value;
-                PropertyChanged?.Invoke(this, new(nameof(CustomExplorer)));
+                selectedCustomBrowserIndex = value;
+                PropertyChanged?.Invoke(this, new(nameof(CustomBrowser)));
             }
         }
         public ObservableCollection<CustomBrowserViewModel> CustomBrowsers { get; set; }
 
-        public CustomBrowserViewModel CustomExplorer => CustomBrowsers[SelectedCustomBrowserIndex];
+        public CustomBrowserViewModel CustomBrowser => CustomBrowsers[SelectedCustomBrowserIndex];
         public SelectBrowserWindow(Settings settings)
         {
             Settings = settings;
@@ -54,7 +54,7 @@ namespace Flow.Launcher
         {
             Settings.CustomBrowserList = CustomBrowsers.ToList();
             Settings.CustomBrowserIndex = SelectedCustomBrowserIndex;
-            Close();
+            Cl ose();
         }
 
         private void btnAdd_Click(object sender, RoutedEventArgs e)