From fee2f0d58872c0a0ab56e16322d7d0bd20015439 Mon Sep 17 00:00:00 2001 From: "Collin M. Barrett" Date: Fri, 25 Sep 2020 20:05:53 -0500 Subject: [PATCH] =?UTF-8?q?Revert=20"fix(logging):=20=F0=9F=90=9B=20try=20?= =?UTF-8?q?yet=20another=20AppInsights=20config"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit a313ce949202d3cc6263b8ff7136a34cf99715de. --- .../HostRunner.cs | 27 +++++-------------- 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/services/SharedKernel/FilterLists.SharedKernel.Logging/HostRunner.cs b/services/SharedKernel/FilterLists.SharedKernel.Logging/HostRunner.cs index c91a2a0ad..1f5eec3a5 100644 --- a/services/SharedKernel/FilterLists.SharedKernel.Logging/HostRunner.cs +++ b/services/SharedKernel/FilterLists.SharedKernel.Logging/HostRunner.cs @@ -1,7 +1,6 @@ using System; using System.Threading.Tasks; using Microsoft.ApplicationInsights.Extensibility; -using Microsoft.Extensions.Configuration; using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.Hosting; using Serilog; @@ -14,7 +13,13 @@ public static async Task TryRunWithLoggingAsync(this IHost host, Func? run { _ = host ?? throw new ArgumentNullException(nameof(host)); - InitializeLogger(host); + Log.Logger = ConfigurationBuilder.BaseLoggerConfiguration + .WriteTo.Conditional( + _ => host.Services.GetService().IsProduction(), + c => c.ApplicationInsights( + TelemetryConfiguration.CreateDefault(), + TelemetryConverter.Traces)) + .CreateLogger(); try { @@ -37,23 +42,5 @@ public static async Task TryRunWithLoggingAsync(this IHost host, Func? run Log.CloseAndFlush(); } } - - private static void InitializeLogger(IHost host) - { - var hostEnvironment = host.Services.GetRequiredService(); - Log.Logger = ConfigurationBuilder.BaseLoggerConfiguration - .ReadFrom.Configuration(host.Services.GetRequiredService()) - .Enrich.WithProperty("Application", hostEnvironment.ApplicationName) - .Enrich.WithProperty("Environment", hostEnvironment.EnvironmentName) - .WriteTo.Conditional( - _ => !hostEnvironment.IsProduction(), - sc => sc.Console().WriteTo.Debug()) - .WriteTo.Conditional( - _ => hostEnvironment.IsProduction(), - sc => sc.ApplicationInsights( - host.Services.GetRequiredService(), - TelemetryConverter.Traces)) - .CreateLogger(); - } } }