From eb0fa51806b34d863b03cee60213d2755e41463d Mon Sep 17 00:00:00 2001 From: Collin Barrett <6483057+collinbarrett@users.noreply.github.com> Date: Thu, 29 May 2025 19:20:29 -0500 Subject: [PATCH] refactor(aspire): de-dup add ot --- services/FilterLists.ServiceDefaults/Extensions.cs | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/services/FilterLists.ServiceDefaults/Extensions.cs b/services/FilterLists.ServiceDefaults/Extensions.cs index 0eaa3adcb..43ba90556 100644 --- a/services/FilterLists.ServiceDefaults/Extensions.cs +++ b/services/FilterLists.ServiceDefaults/Extensions.cs @@ -40,7 +40,7 @@ private static void ConfigureOpenTelemetry(this TBuilder builder) wher logging.IncludeScopes = true; }); - builder.Services.AddOpenTelemetry() + var otBuilder = builder.Services.AddOpenTelemetry() .WithMetrics(metrics => metrics.AddAspNetCoreInstrumentation() .AddHttpClientInstrumentation() @@ -56,17 +56,11 @@ private static void ConfigureOpenTelemetry(this TBuilder builder) wher ) .AddHttpClientInstrumentation()); - builder.AddOpenTelemetryExporters(); - } - - private static void AddOpenTelemetryExporters(this TBuilder builder) - where TBuilder : IHostApplicationBuilder - { if (!string.IsNullOrWhiteSpace(builder.Configuration["OTEL_EXPORTER_OTLP_ENDPOINT"])) - builder.Services.AddOpenTelemetry().UseOtlpExporter(); + otBuilder.UseOtlpExporter(); if (!string.IsNullOrEmpty(builder.Configuration["APPLICATIONINSIGHTS_CONNECTION_STRING"])) - builder.Services.AddOpenTelemetry().UseAzureMonitor(); + otBuilder.UseAzureMonitor(); } // https://learn.microsoft.com/en-us/dotnet/aspire/fundamentals/health-checks#non-development-environments