From d3b029be844a511aff9667114ab2c2489c290157 Mon Sep 17 00:00:00 2001 From: "Collin M. Barrett" Date: Mon, 14 Sep 2020 09:56:04 -0500 Subject: [PATCH] =?UTF-8?q?refactor(archival):=20=E2=99=BB=20improve=20IDi?= =?UTF-8?q?sposable=20implementation=20per=20S3881?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit https://rules.sonarsource.com/csharp/RSPEC-3881 --- .../Persistence/GitFileArchiver.cs | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/services/Archival/FilterLists.Archival.Infrastructure/Persistence/GitFileArchiver.cs b/services/Archival/FilterLists.Archival.Infrastructure/Persistence/GitFileArchiver.cs index fca487286..07f7c658d 100644 --- a/services/Archival/FilterLists.Archival.Infrastructure/Persistence/GitFileArchiver.cs +++ b/services/Archival/FilterLists.Archival.Infrastructure/Persistence/GitFileArchiver.cs @@ -10,7 +10,7 @@ namespace FilterLists.Archival.Infrastructure.Persistence { - internal class GitFileArchiver : IArchiveFiles + internal sealed class GitFileArchiver : IArchiveFiles { private readonly IList _filePaths = new List(); private readonly ILogger _logger; @@ -52,12 +52,6 @@ public void Commit() } public void Dispose() - { - Dispose(true); - GC.SuppressFinalize(this); - } - - protected virtual void Dispose(bool disposing) { foreach (var file in _filePaths) {