From ce8b5485bb11c8079e9d60e8e8cc473c37cf381a Mon Sep 17 00:00:00 2001
From: "Collin M. Barrett" <collinbarrett@users.noreply.github.com>
Date: Mon, 8 Jul 2019 14:07:35 -0500
Subject: [PATCH] log rather than throw FilterListsApiClient exceptions

---
 .../Infrastructure/Clients/FilterListsApiClient.cs | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/FilterLists.Agent/Infrastructure/Clients/FilterListsApiClient.cs b/src/FilterLists.Agent/Infrastructure/Clients/FilterListsApiClient.cs
index 24ce11f7c..b1b8646eb 100644
--- a/src/FilterLists.Agent/Infrastructure/Clients/FilterListsApiClient.cs
+++ b/src/FilterLists.Agent/Infrastructure/Clients/FilterListsApiClient.cs
@@ -1,8 +1,8 @@
-using System;
-using System.Threading;
+using System.Threading;
 using System.Threading.Tasks;
 using FilterLists.Agent.AppSettings;
 using Microsoft.Extensions.Localization;
+using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 using RestSharp;
 
@@ -11,12 +11,14 @@ namespace FilterLists.Agent.Infrastructure.Clients
     public class FilterListsApiClient : IFilterListsApiClient
     {
         private readonly IStringLocalizer<FilterListsApiClient> _localizer;
+        private readonly ILogger<FilterListsApiClient> _logger;
         private readonly IRestClient _restClient;
 
         public FilterListsApiClient(IStringLocalizer<FilterListsApiClient> stringLocalizer,
-            IOptions<FilterListsApiSettings> filterListsApiOptions)
+            ILogger<FilterListsApiClient> logger, IOptions<FilterListsApiSettings> filterListsApiOptions)
         {
             _localizer = stringLocalizer;
+            _logger = logger;
             _restClient = new RestClient(filterListsApiOptions.Value.BaseUrl) {UserAgent = "FilterLists.Agent"};
         }
 
@@ -24,9 +26,9 @@ public async Task<TResponse> ExecuteAsync<TResponse>(IRestRequest request, Cance
         {
             var response = await _restClient.ExecuteTaskAsync<TResponse>(request, cancellationToken);
             if (response.ErrorException == null)
-                return response.Data;
-            throw new ApplicationException(_localizer["Error retrieving response from the FilterLists API."],
-                response.ErrorException);
+                _logger.LogError(response.ErrorException,
+                    _localizer["Error retrieving response from the FilterLists API."]);
+            return response.Data;
         }
     }
 }
\ No newline at end of file