From bdc82486bff73d853dd46ca49928464dc8acaf5e Mon Sep 17 00:00:00 2001 From: "Collin M. Barrett" Date: Tue, 25 Aug 2020 17:14:39 -0500 Subject: [PATCH] =?UTF-8?q?refactor(directory):=20=F0=9F=8E=A8=20configure?= =?UTF-8?q?=20R#=20not=20to=20rm=20private=20setters=20globally?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- services/FilterLists.sln.DotSettings | 11 ++++++----- .../Persistence/Queries/Entities/Dependent.cs | 2 -- .../Persistence/Queries/Entities/FilterList.cs | 2 -- .../Queries/Entities/FilterListLanguage.cs | 2 -- .../Queries/Entities/FilterListMaintainer.cs | 2 -- .../Persistence/Queries/Entities/FilterListSyntax.cs | 2 -- .../Persistence/Queries/Entities/FilterListTag.cs | 2 -- .../Persistence/Queries/Entities/Fork.cs | 2 -- .../Persistence/Queries/Entities/Language.cs | 2 -- .../Persistence/Queries/Entities/License.cs | 2 -- .../Persistence/Queries/Entities/Maintainer.cs | 2 -- .../Persistence/Queries/Entities/Merge.cs | 2 -- .../Persistence/Queries/Entities/SegmentViewUrl.cs | 2 -- .../Queries/Entities/SegmentViewUrlMirror.cs | 2 -- .../Persistence/Queries/Entities/Software.cs | 2 -- .../Persistence/Queries/Entities/SoftwareSyntax.cs | 2 -- .../Persistence/Queries/Entities/Syntax.cs | 2 -- .../Persistence/Queries/Entities/Tag.cs | 2 -- 18 files changed, 6 insertions(+), 39 deletions(-) diff --git a/services/FilterLists.sln.DotSettings b/services/FilterLists.sln.DotSettings index ade679a6b..887fbac59 100644 --- a/services/FilterLists.sln.DotSettings +++ b/services/FilterLists.sln.DotSettings @@ -1,12 +1,13 @@ - + + <?xml version="1.0" encoding="utf-16"?><Profile name="FilterLists Cleanup"><CSReorderTypeMembers>True</CSReorderTypeMembers><XMLReformatCode>True</XMLReformatCode><CSCodeStyleAttributes ArrangeTypeAccessModifier="True" ArrangeTypeMemberAccessModifier="True" SortModifiers="True" RemoveRedundantParentheses="True" AddMissingParentheses="True" ArrangeBraces="True" ArrangeAttributes="True" ArrangeArgumentsStyle="True" ArrangeCodeBodyStyle="True" ArrangeVarStyle="True" ArrangeTrailingCommas="True" /><RemoveCodeRedundanciesVB>True</RemoveCodeRedundanciesVB><Xaml.RedundantFreezeAttribute>True</Xaml.RedundantFreezeAttribute><Xaml.RemoveRedundantModifiersAttribute>True</Xaml.RemoveRedundantModifiersAttribute><Xaml.RemoveRedundantNameAttribute>True</Xaml.RemoveRedundantNameAttribute><Xaml.RemoveRedundantResource>True</Xaml.RemoveRedundantResource><Xaml.RemoveRedundantCollectionProperty>True</Xaml.RemoveRedundantCollectionProperty><Xaml.RemoveRedundantAttachedPropertySetter>True</Xaml.RemoveRedundantAttachedPropertySetter><Xaml.RemoveRedundantStyledValue>True</Xaml.RemoveRedundantStyledValue><Xaml.RemoveRedundantNamespaceAlias>True</Xaml.RemoveRedundantNamespaceAlias><Xaml.RemoveForbiddenResourceName>True</Xaml.RemoveForbiddenResourceName><Xaml.RemoveRedundantGridDefinitionsAttribute>True</Xaml.RemoveRedundantGridDefinitionsAttribute><Xaml.RemoveRedundantGridSpanAttribut>True</Xaml.RemoveRedundantGridSpanAttribut><Xaml.RemoveRedundantUpdateSourceTriggerAttribute>True</Xaml.RemoveRedundantUpdateSourceTriggerAttribute><Xaml.RemoveRedundantBindingModeAttribute>True</Xaml.RemoveRedundantBindingModeAttribute><FormatAttributeQuoteDescriptor>True</FormatAttributeQuoteDescriptor><CorrectVariableKindsDescriptor>True</CorrectVariableKindsDescriptor><VariablesToInnerScopesDescriptor>True</VariablesToInnerScopesDescriptor><StringToTemplatesDescriptor>True</StringToTemplatesDescriptor><RemoveRedundantQualifiersTs>True</RemoveRedundantQualifiersTs><OptimizeImportsTs>True</OptimizeImportsTs><OptimizeReferenceCommentsTs>True</OptimizeReferenceCommentsTs><PublicModifierStyleTs>True</PublicModifierStyleTs><ExplicitAnyTs>True</ExplicitAnyTs><TypeAnnotationStyleTs>True</TypeAnnotationStyleTs><RelativePathStyleTs>True</RelativePathStyleTs><AsInsteadOfCastTs>True</AsInsteadOfCastTs><CssAlphabetizeProperties>True</CssAlphabetizeProperties><JsInsertSemicolon>True</JsInsertSemicolon><JsReformatCode>True</JsReformatCode><JsFormatDocComments>True</JsFormatDocComments><HtmlReformatCode>True</HtmlReformatCode><AspOptimizeRegisterDirectives>True</AspOptimizeRegisterDirectives><VBOptimizeImports>True</VBOptimizeImports><VBShortenReferences>True</VBShortenReferences><RemoveCodeRedundancies>True</RemoveCodeRedundancies><CSUseAutoProperty>True</CSUseAutoProperty><CSMakeFieldReadonly>True</CSMakeFieldReadonly><CSArrangeQualifiers>True</CSArrangeQualifiers><CSFixBuiltinTypeReferences>True</CSFixBuiltinTypeReferences><CssReformatCode>True</CssReformatCode><VBReformatCode>True</VBReformatCode><VBFormatDocComments>True</VBFormatDocComments><CSOptimizeUsings><OptimizeUsings>True</OptimizeUsings><EmbraceInRegion>False</EmbraceInRegion><RegionName></RegionName></CSOptimizeUsings><CSShortenReferences>True</CSShortenReferences><CSReformatCode>True</CSReformatCode><CSharpFormatDocComments>True</CSharpFormatDocComments></Profile> + FilterLists Cleanup NEVER False True CHOP_IF_LONG CHOP_IF_LONG CHOP_IF_LONG - True - True - True - True True \ No newline at end of file diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Dependent.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Dependent.cs index f12422902..75ec063f5 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Dependent.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Dependent.cs @@ -1,11 +1,9 @@ using System; -using System.Diagnostics.CodeAnalysis; using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class Dependent { public int DependencyFilterListId { get; private set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterList.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterList.cs index f70ac3147..375a221fe 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterList.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterList.cs @@ -1,12 +1,10 @@ using System; using System.Collections.Generic; -using System.Diagnostics.CodeAnalysis; using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class FilterList { public int Id { get; private set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListLanguage.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListLanguage.cs index 3c93d6f10..1902e32ba 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListLanguage.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListLanguage.cs @@ -1,11 +1,9 @@ using System; -using System.Diagnostics.CodeAnalysis; using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class FilterListLanguage { public int FilterListId { get; private set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListMaintainer.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListMaintainer.cs index b8e865e22..cfc618a26 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListMaintainer.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListMaintainer.cs @@ -1,11 +1,9 @@ using System; -using System.Diagnostics.CodeAnalysis; using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class FilterListMaintainer { public int FilterListId { get; private set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListSyntax.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListSyntax.cs index b7108f391..3d621a4ea 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListSyntax.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListSyntax.cs @@ -1,11 +1,9 @@ using System; -using System.Diagnostics.CodeAnalysis; using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class FilterListSyntax { public int FilterListId { get; private set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListTag.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListTag.cs index 0b92b07ad..660dbc6bd 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListTag.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListTag.cs @@ -1,11 +1,9 @@ using System; -using System.Diagnostics.CodeAnalysis; using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class FilterListTag { public int FilterListId { get; private set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Fork.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Fork.cs index 8811be8f0..ab58246f2 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Fork.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Fork.cs @@ -1,11 +1,9 @@ using System; -using System.Diagnostics.CodeAnalysis; using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class Fork { public int UpstreamFilterListId { get; private set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Language.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Language.cs index ea09e2b52..1b45d4c63 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Language.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Language.cs @@ -1,12 +1,10 @@ using System; using System.Collections.Generic; -using System.Diagnostics.CodeAnalysis; using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class Language { public string Iso6391 { get; private set; } = null!; diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/License.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/License.cs index ac743c606..ee03271e2 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/License.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/License.cs @@ -1,10 +1,8 @@ using System; using System.Collections.Generic; -using System.Diagnostics.CodeAnalysis; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class License { public int Id { get; private set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Maintainer.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Maintainer.cs index d75cb3f1e..ad75c0413 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Maintainer.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Maintainer.cs @@ -1,10 +1,8 @@ using System; using System.Collections.Generic; -using System.Diagnostics.CodeAnalysis; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class Maintainer { public int Id { get; private set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Merge.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Merge.cs index 69e1b8c21..18d70f924 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Merge.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Merge.cs @@ -1,11 +1,9 @@ using System; -using System.Diagnostics.CodeAnalysis; using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class Merge { public int IncludedInFilterListId { get; set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SegmentViewUrl.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SegmentViewUrl.cs index e5b2ca250..49147660e 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SegmentViewUrl.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SegmentViewUrl.cs @@ -1,10 +1,8 @@ using System; using System.Collections.Generic; -using System.Diagnostics.CodeAnalysis; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class SegmentViewUrl { public FilterList FilterList { get; private set; } = null!; diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SegmentViewUrlMirror.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SegmentViewUrlMirror.cs index 285215e70..41ffee9aa 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SegmentViewUrlMirror.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SegmentViewUrlMirror.cs @@ -1,9 +1,7 @@ using System; -using System.Diagnostics.CodeAnalysis; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class SegmentViewUrlMirror { public SegmentViewUrl SegmentViewUrl { get; private set; } = null!; diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Software.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Software.cs index 022a485a7..b48a772e7 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Software.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Software.cs @@ -1,10 +1,8 @@ using System; using System.Collections.Generic; -using System.Diagnostics.CodeAnalysis; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class Software { public int Id { get; private set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SoftwareSyntax.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SoftwareSyntax.cs index 3c7cc5474..9d35c7a54 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SoftwareSyntax.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SoftwareSyntax.cs @@ -1,11 +1,9 @@ using System; -using System.Diagnostics.CodeAnalysis; using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class SoftwareSyntax { public int SoftwareId { get; private set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Syntax.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Syntax.cs index 5ba15f57b..a4bddd20f 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Syntax.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Syntax.cs @@ -1,10 +1,8 @@ using System; using System.Collections.Generic; -using System.Diagnostics.CodeAnalysis; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class Syntax { public int Id { get; private set; } diff --git a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Tag.cs b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Tag.cs index 9ee0c301c..8073d3cd6 100644 --- a/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Tag.cs +++ b/services/directory/src/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Tag.cs @@ -1,9 +1,7 @@ using System.Collections.Generic; -using System.Diagnostics.CodeAnalysis; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities { - [SuppressMessage("ReSharper", "AutoPropertyCanBeMadeGetOnly.Local")] public class Tag { public int Id { get; private set; }