From 92c004a60acd0fbc970ef828ae7edef3b16993df Mon Sep 17 00:00:00 2001
From: Collin Barrett <collinbarrett@users.noreply.github.com>
Date: Sun, 28 Jan 2018 20:45:52 -0600
Subject: [PATCH] adding rules shouldn't be async

---
 src/FilterLists.Services/Services/ScrapeService.cs | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/FilterLists.Services/Services/ScrapeService.cs b/src/FilterLists.Services/Services/ScrapeService.cs
index 896e75fa2..6f839a2cb 100644
--- a/src/FilterLists.Services/Services/ScrapeService.cs
+++ b/src/FilterLists.Services/Services/ScrapeService.cs
@@ -24,7 +24,7 @@ public async Task ScrapeAsync(int batchSize)
         {
             var lists = await GetNextFilterListDtosToScrape(batchSize);
             var snapshots = await GetSnapshots(lists);
-            await AddOrUpdateRules(snapshots);
+            AddOrUpdateRules(snapshots);
         }
 
         private async Task<IEnumerable<FilterListDto>> GetNextFilterListDtosToScrape(int batchSize)
@@ -60,13 +60,14 @@ private static async Task<string> GetContent(string url)
             return null;
         }
 
-        private async Task AddOrUpdateRules(IEnumerable<Snapshot> snapshots)
+        private void AddOrUpdateRules(IEnumerable<Snapshot> snapshots)
         {
-            await Task.WhenAll(snapshots.Select(async snapshot => await AddOrUpdateRules(snapshot)));
+            foreach (var snapshot in snapshots)
+                AddOrUpdateRules(snapshot);
         }
 
         //TODO: finish and validate
-        private async Task AddOrUpdateRules(Snapshot snapshot)
+        private void AddOrUpdateRules(Snapshot snapshot)
         {
             // add new Rules
             var snapshotRulesRaw =
@@ -97,7 +98,7 @@ private async Task AddOrUpdateRules(Snapshot snapshot)
 
             //TODO: update FilterList.ScrapedDateUtc
 
-            await filterListsDbContext.SaveChangesAsync();
+            filterListsDbContext.SaveChangesAsync();
         }
 
         private class FilterListDto