From 8dc6d5d4275c70906880dd00de5be0773d450ad6 Mon Sep 17 00:00:00 2001
From: "Collin M. Barrett" <collinbarrett@users.noreply.github.com>
Date: Sat, 29 Aug 2020 09:18:44 -0500
Subject: [PATCH] =?UTF-8?q?Revert=20"refactor(web):=20=E2=99=BB?=
 =?UTF-8?q?=F0=9F=9A=A7=20match=20dto=20interfaces=20with=20revised=20api/?=
 =?UTF-8?q?data=20model"?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This reverts commit cf01a8260b62ab291ef2e9887def3523c3562b98.
---
 .../listInfoDrawer/ListInfoDrawer.tsx         |  2 +-
 web/src/components/listsTable/ListDrawer.tsx  |  4 +--
 web/src/components/listsTable/ListsTable.tsx  | 14 ++++----
 .../maintainerCloud/MaintainerCloud.tsx       |  4 +--
 .../components/maintainers/Maintainers.tsx    |  4 +--
 web/src/interfaces/Language.ts                |  3 +-
 web/src/interfaces/License.ts                 |  7 ++--
 web/src/interfaces/List.ts                    | 36 +++++++++----------
 web/src/interfaces/Maintainer.ts              |  6 ++--
 web/src/interfaces/Software.ts                |  6 ++--
 web/src/interfaces/Syntax.ts                  |  5 ++-
 web/src/interfaces/Tag.ts                     |  2 +-
 12 files changed, 42 insertions(+), 51 deletions(-)

diff --git a/web/src/components/listInfoDrawer/ListInfoDrawer.tsx b/web/src/components/listInfoDrawer/ListInfoDrawer.tsx
index 825b7200a..9a80c9b4b 100644
--- a/web/src/components/listInfoDrawer/ListInfoDrawer.tsx
+++ b/web/src/components/listInfoDrawer/ListInfoDrawer.tsx
@@ -80,7 +80,7 @@ export const ListInfoDrawer = (props: RouteComponentProps & Props) => {
       {props.syntax && (
         <SyntaxTag
           name={props.syntax.name}
-          definitionUrl={props.syntax.url}
+          definitionUrl={props.syntax.definitionUrl}
           showLabel={true}
         />
       )}
diff --git a/web/src/components/listsTable/ListDrawer.tsx b/web/src/components/listsTable/ListDrawer.tsx
index 0baac49b6..7c23b7074 100644
--- a/web/src/components/listsTable/ListDrawer.tsx
+++ b/web/src/components/listsTable/ListDrawer.tsx
@@ -32,9 +32,9 @@ export const ListDrawer = (props: Props) => {
       <ListInfoDrawer
         list={list as List}
         languages={
-          list.languageIso6391s &&
+          list.languageIds &&
           props.languages.filter((l: Language) =>
-            list.languageIso6391s.includes(l.id)
+            list.languageIds.includes(l.id)
           )
         }
         license={
diff --git a/web/src/components/listsTable/ListsTable.tsx b/web/src/components/listsTable/ListsTable.tsx
index 9625dac63..c1f9af73f 100644
--- a/web/src/components/listsTable/ListsTable.tsx
+++ b/web/src/components/listsTable/ListsTable.tsx
@@ -217,7 +217,10 @@ export const ListsTable = (props: RouteComponentProps & Props) => {
           render={(syntaxId: number) => {
             const syntax = syntaxes.find((s) => s.id === syntaxId);
             return syntax ? (
-              <SyntaxTag name={syntax.name} definitionUrl={syntax.url} />
+              <SyntaxTag
+                name={syntax.name}
+                definitionUrl={syntax.definitionUrl}
+              />
             ) : null;
           }}
         />
@@ -228,7 +231,7 @@ export const ListsTable = (props: RouteComponentProps & Props) => {
           key="Languages"
           dataIndex={nameof<List>("languageIds")}
           sorter={(a, b) =>
-            arraySorter(a.languageIso6391s, b.languageIso6391s, languages)
+            arraySorter(a.languageIds, b.languageIds, languages)
           }
           width={129}
           className={styles.nogrow}
@@ -239,8 +242,7 @@ export const ListsTable = (props: RouteComponentProps & Props) => {
                 {l.name}&nbsp; (
                 {
                   visibleLists.filter(
-                    (li) =>
-                      li.languageIso6391s && li.languageIso6391s.includes(l.id)
+                    (li) => li.languageIds && li.languageIds.includes(l.id)
                   ).length
                 }
                 )
@@ -249,9 +251,7 @@ export const ListsTable = (props: RouteComponentProps & Props) => {
             value: l.id.toString(),
           }))}
           onFilter={(value, record) =>
-            record.languageIso6391s
-              ? record.languageIso6391s.includes(+value)
-              : false
+            record.languageIds ? record.languageIds.includes(+value) : false
           }
           render={(languageIds: number[]) =>
             languageIds ? (
diff --git a/web/src/components/maintainerCloud/MaintainerCloud.tsx b/web/src/components/maintainerCloud/MaintainerCloud.tsx
index 8974874da..155b92fe1 100644
--- a/web/src/components/maintainerCloud/MaintainerCloud.tsx
+++ b/web/src/components/maintainerCloud/MaintainerCloud.tsx
@@ -12,10 +12,10 @@ export const MaintainerCloud = (props: Props) =>
   props.maintainers && props.maintainers.length ? (
     <div className={styles.grow}>
       {props.maintainers.map((m: Maintainer, i: number) =>
-        m.url ? (
+        m.homeUrl ? (
           <Tag key={i}>
             <a
-              href={m.url}
+              href={m.homeUrl}
               title={`View ${m.name}'s homepage.`}
               target="_blank"
               rel="noopener noreferrer"
diff --git a/web/src/components/maintainers/Maintainers.tsx b/web/src/components/maintainers/Maintainers.tsx
index 291d8ed0f..ee51c764a 100644
--- a/web/src/components/maintainers/Maintainers.tsx
+++ b/web/src/components/maintainers/Maintainers.tsx
@@ -27,10 +27,10 @@ interface MaintainerComponentProps {
 
 const MaintainerComponent = (props: MaintainerComponentProps) => {
   let actions = [];
-  if (props.maintainer.url) {
+  if (props.maintainer.homeUrl) {
     actions.push(
       <a
-        href={props.maintainer.url}
+        href={props.maintainer.homeUrl}
         title={`View ${props.maintainer.name}'s homepage.`}
         target="_blank"
         rel="noopener noreferrer"
diff --git a/web/src/interfaces/Language.ts b/web/src/interfaces/Language.ts
index f08db784b..af4d69de7 100644
--- a/web/src/interfaces/Language.ts
+++ b/web/src/interfaces/Language.ts
@@ -1,5 +1,6 @@
 export interface Language {
+  id: number;
+  filterListIds: number[];
   iso6391: string;
   name: string;
-  filterListIds: number[];
 }
diff --git a/web/src/interfaces/License.ts b/web/src/interfaces/License.ts
index 0335c8e4b..841df2905 100644
--- a/web/src/interfaces/License.ts
+++ b/web/src/interfaces/License.ts
@@ -1,9 +1,6 @@
 export interface License {
   id: number;
-  name: string;
-  url: string;
-  permitsModification: boolean;
-  permitsDistribution: boolean;
-  permitsCommercialUse: boolean;
+  descriptionUrl: string;
   filterListIds: number[];
+  name: string;
 }
diff --git a/web/src/interfaces/List.ts b/web/src/interfaces/List.ts
index fe595812b..901184ab1 100644
--- a/web/src/interfaces/List.ts
+++ b/web/src/interfaces/List.ts
@@ -1,28 +1,24 @@
 export interface List {
   id: number;
-  name: string;
-  description: string;
-  licenseId: number;
-  syntaxIds: number[];
-  languageIso6391s: number[];
-  tagIds: number[];
-  // viewUrls: unknown[];
-  homeUrl: string;
-  onionUrl: string;
-  policyUrl: string;
-  submissionUrl: string;
-  issuesUrl: string;
-  forumUrl: string;
   chatUrl: string;
-  emailAddress: string;
+  description: string;
+  descriptionSourceUrl: string;
   donateUrl: string;
+  emailAddress: string;
+  forumUrl: string;
+  homeUrl: string;
+  issuesUrl: string;
+  languageIds: number[];
+  licenseId: number;
   maintainerIds: number[];
-  upstreamFilterListIds: number[];
-  forkFilterListIds: number[];
-  includedInFilterListIds: number[];
-  includesFilterListIds: number[];
-  dependencyFilterListIds: number[];
-  dependentFilterListIds: number[];
+  name: string;
+  policyUrl: string;
+  publishedDate: string;
+  submissionUrl: string;
+  syntaxId: number;
+  tagIds: number[];
+  viewUrl: string;
+  viewUrlMirrors: string[];
 
   // auto-generated by useLists hook
   slug: string;
diff --git a/web/src/interfaces/Maintainer.ts b/web/src/interfaces/Maintainer.ts
index bd2f319c0..aa3746832 100644
--- a/web/src/interfaces/Maintainer.ts
+++ b/web/src/interfaces/Maintainer.ts
@@ -1,8 +1,8 @@
 export interface Maintainer {
   id: number;
-  name: string;
-  url: string;
   emailAddress: string;
-  twitterHandle: string;
   filterListIds: number[];
+  homeUrl: string;
+  name: string;
+  twitterHandle: string;
 }
diff --git a/web/src/interfaces/Software.ts b/web/src/interfaces/Software.ts
index 5a2b09fba..dd8d151ac 100644
--- a/web/src/interfaces/Software.ts
+++ b/web/src/interfaces/Software.ts
@@ -1,9 +1,7 @@
 export interface Software {
   id: number;
-  name: string;
-  description: string;
   homeUrl: string;
-  downloadUrl: string;
-  supportsAbpUrlScheme: boolean;
+  isAbpSubscribable: boolean;
+  name: string;
   syntaxIds: number[];
 }
diff --git a/web/src/interfaces/Syntax.ts b/web/src/interfaces/Syntax.ts
index 0457c34b0..0873306d9 100644
--- a/web/src/interfaces/Syntax.ts
+++ b/web/src/interfaces/Syntax.ts
@@ -1,8 +1,7 @@
 export interface Syntax {
   id: number;
-  name: string;
-  description: string;
-  url: string;
+  definitionUrl: string;
   filterListIds: number[];
+  name: string;
   softwareIds: number[];
 }
diff --git a/web/src/interfaces/Tag.ts b/web/src/interfaces/Tag.ts
index 9cf1d5592..4141dd434 100644
--- a/web/src/interfaces/Tag.ts
+++ b/web/src/interfaces/Tag.ts
@@ -1,6 +1,6 @@
 export interface Tag {
   id: number;
-  name: string;
   description: string;
   filterListIds: number[];
+  name: string;
 }