From 8cabf0f725f8a59252694fe8b3d5156cc9c2bd6f Mon Sep 17 00:00:00 2001 From: "Collin M. Barrett" Date: Tue, 29 Sep 2020 07:48:15 -0500 Subject: [PATCH] =?UTF-8?q?refactor(services):=20=E2=99=BB=20downgrade=20C?= =?UTF-8?q?A1062=20since=20app=20is=20fully=20nullable=20reference=20type?= =?UTF-8?q?=20enabled?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- services/.editorconfig | 1 + .../Commands/ArchiveList.cs | 4 +--- .../ConfigurationExtensions.cs | 5 +---- .../FilterLists.Archival.Domain/SeedWork/ValueObject.cs | 5 +---- .../ConfigurationExtensions.cs | 5 +---- .../Persistence/FileWriteStrategies/PlainText.cs | 5 +---- .../Persistence/Queries/Context/QueryDbContext.cs | 2 -- .../Persistence/Queries/Entities/Dependent.cs | 4 +--- .../Persistence/Queries/Entities/FilterList.cs | 1 - .../Persistence/Queries/Entities/FilterListLanguage.cs | 4 +--- .../Persistence/Queries/Entities/FilterListMaintainer.cs | 4 +--- .../Persistence/Queries/Entities/FilterListSyntax.cs | 4 +--- .../Persistence/Queries/Entities/FilterListTag.cs | 4 +--- .../Persistence/Queries/Entities/FilterListViewUrl.cs | 1 - .../Persistence/Queries/Entities/Fork.cs | 4 +--- .../Persistence/Queries/Entities/Language.cs | 4 +--- .../Persistence/Queries/Entities/License.cs | 1 - .../Persistence/Queries/Entities/Maintainer.cs | 1 - .../Persistence/Queries/Entities/Merge.cs | 4 +--- .../Persistence/Queries/Entities/Software.cs | 1 - .../Persistence/Queries/Entities/SoftwareSyntax.cs | 4 +--- .../Persistence/Queries/Entities/Syntax.cs | 1 - .../Persistence/Queries/Entities/Tag.cs | 4 +--- .../Persistence/SeedExtensions.cs | 7 +------ .../ConfigurationExtensions.cs | 5 +---- .../FilterLists.SharedKernel.Logging/HostRunner.cs | 2 -- 26 files changed, 18 insertions(+), 69 deletions(-) diff --git a/services/.editorconfig b/services/.editorconfig index b1058a501..79fe8b9e9 100644 --- a/services/.editorconfig +++ b/services/.editorconfig @@ -127,5 +127,6 @@ visual_basic_preferred_modifier_order = Partial,Default,Private,Protected,Public # FilterLists Services custom pairs [*.cs] +dotnet_diagnostic.CA1062.severity = suggestion dotnet_diagnostic.CA1812.severity = suggestion dotnet_diagnostic.CA2007.severity = none \ No newline at end of file diff --git a/services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs b/services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs index 8292a5132..6d1168944 100644 --- a/services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs +++ b/services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs @@ -1,5 +1,4 @@ -using System; -using System.Collections.Generic; +using System.Collections.Generic; using System.Globalization; using System.IO; using System.Linq; @@ -48,7 +47,6 @@ public Handler( public async Task Handle(Command request, CancellationToken cancellationToken) { - _ = request ?? throw new ArgumentNullException(nameof(request)); _logger.LogInformation("Archiving list {ListId}", request.ListId); var segmentUrls = (await GetSegmentUrlsAsync(request.ListId, cancellationToken)).ToList(); diff --git a/services/Archival/FilterLists.Archival.Application/ConfigurationExtensions.cs b/services/Archival/FilterLists.Archival.Application/ConfigurationExtensions.cs index 15f795244..725995984 100644 --- a/services/Archival/FilterLists.Archival.Application/ConfigurationExtensions.cs +++ b/services/Archival/FilterLists.Archival.Application/ConfigurationExtensions.cs @@ -1,5 +1,4 @@ -using System; -using FilterLists.Archival.Application.Commands; +using FilterLists.Archival.Application.Commands; using FilterLists.Archival.Infrastructure; using FilterLists.Archival.Infrastructure.Scheduling; using MediatR; @@ -31,8 +30,6 @@ public static void UseApplication(this IApplicationBuilder app) private static void ScheduleArchival(this IApplicationBuilder app) { - _ = app ?? throw new ArgumentNullException(nameof(app)); - #if DEBUG new EnqueueArchiveAllLists.Command().EnqueueBackgroundJob(); #else diff --git a/services/Archival/FilterLists.Archival.Domain/SeedWork/ValueObject.cs b/services/Archival/FilterLists.Archival.Domain/SeedWork/ValueObject.cs index 6676bd00c..7e0df9426 100644 --- a/services/Archival/FilterLists.Archival.Domain/SeedWork/ValueObject.cs +++ b/services/Archival/FilterLists.Archival.Domain/SeedWork/ValueObject.cs @@ -1,5 +1,4 @@ -using System; -using System.Collections.Generic; +using System.Collections.Generic; using System.Linq; namespace FilterLists.Archival.Domain.SeedWork @@ -8,8 +7,6 @@ public abstract class ValueObject { protected static bool EqualOperator(ValueObject left, ValueObject right) { - _ = left ?? throw new ArgumentNullException(nameof(left)); - return left.Equals(right); } diff --git a/services/Archival/FilterLists.Archival.Infrastructure/ConfigurationExtensions.cs b/services/Archival/FilterLists.Archival.Infrastructure/ConfigurationExtensions.cs index 1838d468c..875947439 100644 --- a/services/Archival/FilterLists.Archival.Infrastructure/ConfigurationExtensions.cs +++ b/services/Archival/FilterLists.Archival.Infrastructure/ConfigurationExtensions.cs @@ -1,5 +1,4 @@ -using System; -using FilterLists.Archival.Infrastructure.Clients; +using FilterLists.Archival.Infrastructure.Clients; using FilterLists.Archival.Infrastructure.Persistence; using FilterLists.Archival.Infrastructure.Scheduling; using FilterLists.Directory.Api.Contracts; @@ -20,8 +19,6 @@ public static IHostBuilder UseInfrastructure(this IHostBuilder hostBuilder) public static void AddInfrastructureServices(this IServiceCollection services, IConfiguration configuration) { - _ = configuration ?? throw new ArgumentNullException(nameof(configuration)); - services.AddSharedKernelLogging(configuration); services.AddSchedulingServices(configuration); services.AddDirectoryApiClient(configuration); diff --git a/services/Archival/FilterLists.Archival.Infrastructure/Persistence/FileWriteStrategies/PlainText.cs b/services/Archival/FilterLists.Archival.Infrastructure/Persistence/FileWriteStrategies/PlainText.cs index 5a9641581..c313a5ed8 100644 --- a/services/Archival/FilterLists.Archival.Infrastructure/Persistence/FileWriteStrategies/PlainText.cs +++ b/services/Archival/FilterLists.Archival.Infrastructure/Persistence/FileWriteStrategies/PlainText.cs @@ -1,5 +1,4 @@ -using System; -using System.IO; +using System.IO; using System.Threading; using FilterLists.Archival.Domain.Lists; @@ -9,8 +8,6 @@ internal class PlainText : IStreamToPlainTextConversionStrategy { public Stream Convert(ListArchiveSegment listArchiveSegment, CancellationToken cancellationToken) { - _ = listArchiveSegment ?? throw new ArgumentNullException(nameof(listArchiveSegment)); - return listArchiveSegment.Content; } } diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Context/QueryDbContext.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Context/QueryDbContext.cs index 405424795..da1098924 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Context/QueryDbContext.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Context/QueryDbContext.cs @@ -34,8 +34,6 @@ public override Task SaveChangesAsync( protected override void OnModelCreating(ModelBuilder modelBuilder) { - _ = modelBuilder ?? throw new ArgumentNullException(nameof(modelBuilder)); - modelBuilder.ApplyConfigurationsFromAssembly(GetType().Assembly); } } diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Dependent.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Dependent.cs index e65fac28e..19475b976 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Dependent.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Dependent.cs @@ -1,5 +1,4 @@ -using System; -using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities @@ -16,7 +15,6 @@ internal class DependentTypeConfiguration : IEntityTypeConfiguration { public virtual void Configure(EntityTypeBuilder builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.ToTable(nameof(Dependent) + "s"); builder.HasKey(d => new {d.DependencyFilterListId, d.DependentFilterListId}); builder.HasOne(d => d.DependencyFilterList) diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterList.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterList.cs index 2de4d0b6c..1a039d88b 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterList.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterList.cs @@ -39,7 +39,6 @@ internal class FilterListTypeConfiguration : IEntityTypeConfiguration builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.HasDataJsonFile(); } } diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListLanguage.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListLanguage.cs index 4cf13a7cb..a8e62076b 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListLanguage.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListLanguage.cs @@ -1,5 +1,4 @@ -using System; -using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities @@ -16,7 +15,6 @@ internal class FilterListLanguageTypeConfiguration : IEntityTypeConfiguration builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.ToTable(nameof(FilterListLanguage) + "s"); builder.HasKey(fll => new {fll.FilterListId, fll.Iso6391}); builder.HasDataJsonFile(); diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListMaintainer.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListMaintainer.cs index 941573699..c36ac2f91 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListMaintainer.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListMaintainer.cs @@ -1,5 +1,4 @@ -using System; -using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities @@ -16,7 +15,6 @@ internal class FilterListMaintainerTypeConfiguration : IEntityTypeConfiguration< { public virtual void Configure(EntityTypeBuilder builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.ToTable(nameof(FilterListMaintainer) + "s"); builder.HasKey(flm => new {flm.FilterListId, flm.MaintainerId}); builder.HasDataJsonFile(); diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListSyntax.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListSyntax.cs index 690f0badc..f691d33a0 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListSyntax.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListSyntax.cs @@ -1,5 +1,4 @@ -using System; -using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities @@ -16,7 +15,6 @@ internal class FilterListSyntaxTypeConfiguration : IEntityTypeConfiguration builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.ToTable(nameof(FilterListSyntax) + "es"); builder.HasKey(fls => new {fls.FilterListId, fls.SyntaxId}); builder.HasDataJsonFile(); diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListTag.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListTag.cs index 442986751..ff6923cdc 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListTag.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListTag.cs @@ -1,5 +1,4 @@ -using System; -using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities @@ -16,7 +15,6 @@ internal class FilterListTagTypeConfiguration : IEntityTypeConfiguration builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.ToTable(nameof(FilterListTag) + "s"); builder.HasKey(flt => new {flt.FilterListId, flt.TagId}); builder.HasDataJsonFile(); diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListViewUrl.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListViewUrl.cs index 26ced06ef..4d057b5ab 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListViewUrl.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/FilterListViewUrl.cs @@ -18,7 +18,6 @@ internal class FilterListViewUrlConfiguration : IEntityTypeConfiguration builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.ToTable(nameof(FilterListViewUrl) + "s"); builder.Property(u => u.SegmentNumber).HasDefaultValue(1); builder.Property(u => u.Primariness).HasDefaultValue(1); diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Fork.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Fork.cs index 8ba37fbf7..f334f3639 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Fork.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Fork.cs @@ -1,5 +1,4 @@ -using System; -using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities @@ -16,7 +15,6 @@ internal class ForkTypeConfiguration : IEntityTypeConfiguration { public virtual void Configure(EntityTypeBuilder builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.ToTable(nameof(Fork) + "s"); builder.HasKey(f => new {f.UpstreamFilterListId, f.ForkFilterListId}); builder.HasOne(f => f.UpstreamFilterList) diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Language.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Language.cs index d44b27783..e9e96471f 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Language.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Language.cs @@ -1,5 +1,4 @@ -using System; -using System.Collections.Generic; +using System.Collections.Generic; using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; @@ -16,7 +15,6 @@ internal class LanguageTypeConfiguration : IEntityTypeConfiguration { public virtual void Configure(EntityTypeBuilder builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.HasKey(l => l.Iso6391); builder.Property(l => l.Iso6391) .IsFixedLength() diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/License.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/License.cs index 474a14155..bbef91a06 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/License.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/License.cs @@ -20,7 +20,6 @@ internal class LicenseTypeConfiguration : IEntityTypeConfiguration { public virtual void Configure(EntityTypeBuilder builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.HasDataJsonFile(); } } diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Maintainer.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Maintainer.cs index 8163c63e3..df4e81ac0 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Maintainer.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Maintainer.cs @@ -19,7 +19,6 @@ internal class MaintainerTypeConfiguration : IEntityTypeConfiguration builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.HasDataJsonFile(); } } diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Merge.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Merge.cs index b017e4042..8f71d05f6 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Merge.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Merge.cs @@ -1,5 +1,4 @@ -using System; -using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities @@ -16,7 +15,6 @@ internal class MergeTypeConfiguration : IEntityTypeConfiguration { public virtual void Configure(EntityTypeBuilder builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.ToTable(nameof(Merge) + "s"); builder.HasKey(m => new {m.IncludedInFilterListId, m.IncludesFilterListId}); builder.HasOne(m => m.IncludedInFilterList) diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Software.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Software.cs index 352fd6507..51ed8c7a4 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Software.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Software.cs @@ -20,7 +20,6 @@ internal class SoftwareTypeConfiguration : IEntityTypeConfiguration { public virtual void Configure(EntityTypeBuilder builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.HasDataJsonFile(); } } diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SoftwareSyntax.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SoftwareSyntax.cs index a03cd1cdf..96734f782 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SoftwareSyntax.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/SoftwareSyntax.cs @@ -1,5 +1,4 @@ -using System; -using Microsoft.EntityFrameworkCore; +using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; namespace FilterLists.Directory.Infrastructure.Persistence.Queries.Entities @@ -16,7 +15,6 @@ internal class SoftwareSyntaxTypeConfiguration : IEntityTypeConfiguration builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.ToTable(nameof(SoftwareSyntax) + "es"); builder.HasKey(ss => new {ss.SoftwareId, ss.SyntaxId}); builder.HasDataJsonFile(); diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Syntax.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Syntax.cs index da3ba3602..a5e47a21d 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Syntax.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Syntax.cs @@ -19,7 +19,6 @@ internal class SyntaxTypeConfiguration : IEntityTypeConfiguration { public virtual void Configure(EntityTypeBuilder builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.HasDataJsonFile(); } } diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Tag.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Tag.cs index cbde195df..1426514d9 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Tag.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/Queries/Entities/Tag.cs @@ -1,5 +1,4 @@ -using System; -using System.Collections.Generic; +using System.Collections.Generic; using Microsoft.EntityFrameworkCore; using Microsoft.EntityFrameworkCore.Metadata.Builders; @@ -17,7 +16,6 @@ internal class TagTypeConfiguration : IEntityTypeConfiguration { public virtual void Configure(EntityTypeBuilder builder) { - _ = builder ?? throw new ArgumentNullException(nameof(builder)); builder.HasDataJsonFile(); } } diff --git a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/SeedExtensions.cs b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/SeedExtensions.cs index 9ba6cadcf..23fe7c799 100644 --- a/services/Directory/FilterLists.Directory.Infrastructure/Persistence/SeedExtensions.cs +++ b/services/Directory/FilterLists.Directory.Infrastructure/Persistence/SeedExtensions.cs @@ -1,5 +1,4 @@ -using System; -using System.Collections.Generic; +using System.Collections.Generic; using System.IO; using System.Text.Json; using System.Threading.Tasks; @@ -15,8 +14,6 @@ public static class SeedExtension { public static async Task MigrateAsync(this IHost host) { - _ = host ?? throw new ArgumentNullException(nameof(host)); - using var scope = host.Services.CreateScope(); var db = scope.ServiceProvider.GetRequiredService(); await db.Database.MigrateAsync(); @@ -27,8 +24,6 @@ internal static class SeedConfigurationExtension { public static void HasDataJsonFile(this EntityTypeBuilder entityTypeBuilder) { - _ = entityTypeBuilder ?? throw new ArgumentNullException(nameof(entityTypeBuilder)); - var path = Path.Combine("../data", $"{typeof(TEntity).Name}.json"); if (!File.Exists(path)) { diff --git a/services/SharedKernel/FilterLists.SharedKernel.Logging/ConfigurationExtensions.cs b/services/SharedKernel/FilterLists.SharedKernel.Logging/ConfigurationExtensions.cs index 76ab48a6e..cfae9c7cd 100644 --- a/services/SharedKernel/FilterLists.SharedKernel.Logging/ConfigurationExtensions.cs +++ b/services/SharedKernel/FilterLists.SharedKernel.Logging/ConfigurationExtensions.cs @@ -1,5 +1,4 @@ -using System; -using FilterLists.SharedKernel.Logging.Options; +using FilterLists.SharedKernel.Logging.Options; using Microsoft.ApplicationInsights.Channel; using Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel; using Microsoft.AspNetCore.Builder; @@ -19,8 +18,6 @@ public static IHostBuilder UseLogging(this IHostBuilder hostBuilder) public static void AddSharedKernelLogging(this IServiceCollection services, IConfiguration configuration) { - _ = configuration ?? throw new ArgumentNullException(nameof(configuration)); - using var serverTelemetryChannel = new ServerTelemetryChannel { StorageFolder = configuration.GetSection(ApplicationInsightsOptions.Key) diff --git a/services/SharedKernel/FilterLists.SharedKernel.Logging/HostRunner.cs b/services/SharedKernel/FilterLists.SharedKernel.Logging/HostRunner.cs index 4d3818236..7c8919bb2 100644 --- a/services/SharedKernel/FilterLists.SharedKernel.Logging/HostRunner.cs +++ b/services/SharedKernel/FilterLists.SharedKernel.Logging/HostRunner.cs @@ -11,8 +11,6 @@ public static class HostRunner { public static async Task TryRunWithLoggingAsync(this IHost host, Func? runPreHostAsync = default) { - _ = host ?? throw new ArgumentNullException(nameof(host)); - Log.Logger = ConfigurationBuilder.BaseLoggerConfiguration .WriteTo.ApplicationInsights( host.Services.GetRequiredService(),