From 824e450ccb3316c85a20133a2a3a00d6e6888757 Mon Sep 17 00:00:00 2001 From: "Collin M. Barrett" Date: Sun, 13 Sep 2020 14:33:29 -0500 Subject: [PATCH] =?UTF-8?q?fix(services):=20=F0=9F=90=9B=20resolve=20warni?= =?UTF-8?q?ngs?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- services/.editorconfig | 5 +++++ .../Archival/FilterLists.Archival.Application/.editorconfig | 6 ++++++ .../FilterLists.Directory.Application/.editorconfig | 6 ++++++ .../.editorconfig | 5 +++++ .../.editorconfig | 5 +++++ .../FilterLists.SharedKernel.Logging/HostRunner.cs | 2 +- 6 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 services/Archival/FilterLists.Archival.Application/.editorconfig create mode 100644 services/Directory/FilterLists.Directory.Application/.editorconfig create mode 100644 services/Directory/FilterLists.Directory.Infrastructure.Migrations.Tests/.editorconfig create mode 100644 services/Directory/FilterLists.Directory.Infrastructure.Migrations/.editorconfig diff --git a/services/.editorconfig b/services/.editorconfig index 6071d7b7f..8be0b59b8 100644 --- a/services/.editorconfig +++ b/services/.editorconfig @@ -7,3 +7,8 @@ indent_style = space # Xml files [*.xml] indent_size = 2 + +# Code quality analysis +[*.cs] +dotnet_diagnostic.CA1812.severity = suggestion +dotnet_diagnostic.CA2007.severity = none \ No newline at end of file diff --git a/services/Archival/FilterLists.Archival.Application/.editorconfig b/services/Archival/FilterLists.Archival.Application/.editorconfig new file mode 100644 index 000000000..ae3e826ae --- /dev/null +++ b/services/Archival/FilterLists.Archival.Application/.editorconfig @@ -0,0 +1,6 @@ +# To learn more about .editorconfig see https://aka.ms/editorconfigdocs + +# Code quality analysis +[*.cs] +dotnet_diagnostic.CA1034.severity = suggestion +dotnet_diagnostic.CA1724.severity = suggestion \ No newline at end of file diff --git a/services/Directory/FilterLists.Directory.Application/.editorconfig b/services/Directory/FilterLists.Directory.Application/.editorconfig new file mode 100644 index 000000000..ae3e826ae --- /dev/null +++ b/services/Directory/FilterLists.Directory.Application/.editorconfig @@ -0,0 +1,6 @@ +# To learn more about .editorconfig see https://aka.ms/editorconfigdocs + +# Code quality analysis +[*.cs] +dotnet_diagnostic.CA1034.severity = suggestion +dotnet_diagnostic.CA1724.severity = suggestion \ No newline at end of file diff --git a/services/Directory/FilterLists.Directory.Infrastructure.Migrations.Tests/.editorconfig b/services/Directory/FilterLists.Directory.Infrastructure.Migrations.Tests/.editorconfig new file mode 100644 index 000000000..749db81b0 --- /dev/null +++ b/services/Directory/FilterLists.Directory.Infrastructure.Migrations.Tests/.editorconfig @@ -0,0 +1,5 @@ +# To learn more about .editorconfig see https://aka.ms/editorconfigdocs + +# Code quality analysis +[*.cs] +dotnet_diagnostic.CA1707.severity = suggestion \ No newline at end of file diff --git a/services/Directory/FilterLists.Directory.Infrastructure.Migrations/.editorconfig b/services/Directory/FilterLists.Directory.Infrastructure.Migrations/.editorconfig new file mode 100644 index 000000000..2e30c719a --- /dev/null +++ b/services/Directory/FilterLists.Directory.Infrastructure.Migrations/.editorconfig @@ -0,0 +1,5 @@ +# To learn more about .editorconfig see https://aka.ms/editorconfigdocs + +# Code quality analysis +[*.cs] +dotnet_diagnostic.CS8625.severity = suggestion \ No newline at end of file diff --git a/services/SharedKernel/FilterLists.SharedKernel.Logging/HostRunner.cs b/services/SharedKernel/FilterLists.SharedKernel.Logging/HostRunner.cs index d50e5f60c..58feedabe 100644 --- a/services/SharedKernel/FilterLists.SharedKernel.Logging/HostRunner.cs +++ b/services/SharedKernel/FilterLists.SharedKernel.Logging/HostRunner.cs @@ -32,7 +32,7 @@ public static async Task TryRunWithLoggingAsync(this IHost host, Func catch (Exception ex) { Log.Fatal(ex, "Host terminated unexpectedly"); - return 1; + throw; } finally {