From 76ec6a78573e3b49ea0c49e45b5371b5f1acdff1 Mon Sep 17 00:00:00 2001 From: "Collin M. Barrett" Date: Mon, 22 Jan 2018 07:58:51 -0600 Subject: [PATCH] minor efficiency improvement if no values to seed --- src/FilterLists.Data/FilterListsDbContextExtensions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/FilterLists.Data/FilterListsDbContextExtensions.cs b/src/FilterLists.Data/FilterListsDbContextExtensions.cs index 148a15fd2..8b6bbc06e 100644 --- a/src/FilterLists.Data/FilterListsDbContextExtensions.cs +++ b/src/FilterLists.Data/FilterListsDbContextExtensions.cs @@ -44,9 +44,9 @@ private static void InsertOnDuplicateKeyUpdate(this DbContext dbCon { var entityType = dbContext.Model.FindEntityType(typeof(TEntityType)); var properties = GetPropertiesLessValueGeneratedTimestamps(entityType); - var columns = string.Join(", ", properties.Select(x => x.Name)); var values = CreateValues(properties, dataPath); if (values == "") return; + var columns = string.Join(", ", properties.Select(x => x.Name)); var updates = CreateUpdates(properties); var rawSqlString = "INSERT INTO " + entityType.Relational().TableName + " (" + columns + ") VALUES " + values + " ON DUPLICATE KEY UPDATE " + updates;