From 75a37df10845d369d3b9171e361a6010d996508f Mon Sep 17 00:00:00 2001 From: "Collin M. Barrett" Date: Sat, 25 Aug 2018 09:21:49 -0500 Subject: [PATCH] de-async batch saving to try reducing crashes --- src/FilterLists.Services/Snapshot/Batch.cs | 4 ++-- src/FilterLists.Services/Snapshot/Snapshot.cs | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/FilterLists.Services/Snapshot/Batch.cs b/src/FilterLists.Services/Snapshot/Batch.cs index c53467780..7ee61fa05 100644 --- a/src/FilterLists.Services/Snapshot/Batch.cs +++ b/src/FilterLists.Services/Snapshot/Batch.cs @@ -20,11 +20,11 @@ public Batch(FilterListsDbContext dbContext, IEnumerable lines, Data.Ent this.snapEntity = snapEntity; } - public async Task SaveAsync() + public void Save() { var rules = GetOrCreateRules(); CreateSnapRules(rules); - await dbContext.SaveChangesAsync(); + dbContext.SaveChanges(); } private IQueryable GetOrCreateRules() diff --git a/src/FilterLists.Services/Snapshot/Snapshot.cs b/src/FilterLists.Services/Snapshot/Snapshot.cs index f681e6c2a..09442cd70 100644 --- a/src/FilterLists.Services/Snapshot/Snapshot.cs +++ b/src/FilterLists.Services/Snapshot/Snapshot.cs @@ -122,7 +122,7 @@ private async Task GetLines() private async Task SaveInBatches() { var snapBatches = await CreateBatches(); - await SaveBatches(snapBatches); + SaveBatches(snapBatches); } private async Task> CreateBatches() @@ -131,10 +131,10 @@ private async Task> CreateBatches() return lines.Batch(SnapEntity.BatchSize.Value).Select(b => new Batch(dbContext, b, SnapEntity)); } - private static async Task SaveBatches(IEnumerable batches) + private static void SaveBatches(IEnumerable batches) { foreach (var batch in batches) - await batch.SaveAsync(); + batch.Save(); } private async Task SetSuccessful()