From 716cd38284d60cd75963ceb226fdd31b79217740 Mon Sep 17 00:00:00 2001 From: "Collin M. Barrett" Date: Thu, 17 Sep 2020 17:28:41 -0500 Subject: [PATCH] =?UTF-8?q?docs(archival):=20=F0=9F=93=9D=20add=20Polly=20?= =?UTF-8?q?todos?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../FilterLists.Archival.Application/Commands/ArchiveList.cs | 1 + .../ConfigurationExtensions.cs | 1 + 2 files changed, 2 insertions(+) diff --git a/services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs b/services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs index 43dfcf415..1a1b2b744 100644 --- a/services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs +++ b/services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs @@ -92,6 +92,7 @@ private async Task DownloadSegments( var readTasks = new List>(); foreach (var segment in segments) { + // TODO: add Polly for resiliency var response = await _httpClient.GetAsync(segment.Url, HttpCompletionOption.ResponseHeadersRead, cancellationToken); responses.Add(response); response.EnsureSuccessStatusCode(); diff --git a/services/SharedKernel/FilterLists.SharedKernel.Apis.Clients/ConfigurationExtensions.cs b/services/SharedKernel/FilterLists.SharedKernel.Apis.Clients/ConfigurationExtensions.cs index 2fca604fa..c402a5015 100644 --- a/services/SharedKernel/FilterLists.SharedKernel.Apis.Clients/ConfigurationExtensions.cs +++ b/services/SharedKernel/FilterLists.SharedKernel.Apis.Clients/ConfigurationExtensions.cs @@ -10,6 +10,7 @@ public static class ConfigurationExtensions { public static void AddApiClients(this IServiceCollection services, IConfiguration configuration) { + // TODO: add Polly for resiliency // TODO: use SystemTextJsonContentSerializer() once less feature-limited services.AddRefitClient() .ConfigureHttpClient(c =>