prehistoric-systems/FilterLists
1
0
Fork 0
mirror of https://github.com/collinbarrett/FilterLists.git synced 2026-03-11 09:04:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(archival): 🐛 buffer stream to memory so HttpClient doesn't dispose before read completes

Browse source
This commit is contained in:
Collin M. Barrett 2020-09-17 15:53:23 -05:00
parent 67d38b1b15
commit 66cb92eabc
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/Archival/FilterLists.Archival.Application/Commands/ArchiveList.cs
View file

@ -93,7 +93,12 @@ private async Task<Stream> FetchStreamAsync(
{
using var response = await _httpClient.GetAsync(url, cancellationToken);
response.EnsureSuccessStatusCode();
return await response.Content.ReadAsStreamAsync();
var sourceStream = await response.Content.ReadAsStreamAsync();
// TODO: verify efficiency. buffered to MemoryStream because Stream from HttpClient is disposed prematurely
var targetStream = new MemoryStream();
await sourceStream.CopyToAsync(targetStream, cancellationToken);
return targetStream;
}
}
}