From 4c5698472f17e8cbb0ee212ccfa45e2d19cc9559 Mon Sep 17 00:00:00 2001 From: "Collin M. Barrett" Date: Wed, 3 Jul 2019 20:04:04 -0500 Subject: [PATCH] standardize some client ex msgs --- .../Infrastructure/Clients/AgentGitHubClient.cs | 7 ++++--- .../Infrastructure/Clients/FilterListsApiClient.cs | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/FilterLists.Agent/Infrastructure/Clients/AgentGitHubClient.cs b/src/FilterLists.Agent/Infrastructure/Clients/AgentGitHubClient.cs index c67d02cf0..3dc297eb9 100644 --- a/src/FilterLists.Agent/Infrastructure/Clients/AgentGitHubClient.cs +++ b/src/FilterLists.Agent/Infrastructure/Clients/AgentGitHubClient.cs @@ -18,6 +18,7 @@ public interface IAgentGitHubClient public class AgentGitHubClient : IAgentGitHubClient { + private const string ExceptionMessageSuffix = " from the GitHub API."; private readonly GitHubClient _gitHubClient; private readonly GitHub _gitHubOptions; private readonly ILogger _logger; @@ -41,7 +42,7 @@ public async Task> GetAllIssues(RepositoryIssueRequest repo } catch (ApiException ex) { - _logger.LogError(ex, "Failed getting all Issues from the GitHub API."); + _logger.LogError(ex, $"Failed getting all Issues{ExceptionMessageSuffix}"); return null; } } @@ -55,7 +56,7 @@ public async Task CreateIssue(NewIssue newIssue) } catch (ApiException ex) { - _logger.LogError(ex, "Failed creating Issue with the GitHub API."); + _logger.LogError(ex, $"Failed creating Issue{ExceptionMessageSuffix}"); return null; } } @@ -69,7 +70,7 @@ public async Task UpdateIssue(int issueNumber, IssueUpdate issueUpdate) } catch (ApiException ex) { - _logger.LogError(ex, "Failed updating Issue with the GitHub API."); + _logger.LogError(ex, $"Failed updating Issue{ExceptionMessageSuffix}"); return null; } } diff --git a/src/FilterLists.Agent/Infrastructure/Clients/FilterListsApiClient.cs b/src/FilterLists.Agent/Infrastructure/Clients/FilterListsApiClient.cs index c639f9003..e2495f856 100644 --- a/src/FilterLists.Agent/Infrastructure/Clients/FilterListsApiClient.cs +++ b/src/FilterLists.Agent/Infrastructure/Clients/FilterListsApiClient.cs @@ -12,7 +12,7 @@ public interface IFilterListsApiClient public class FilterListsApiClient : IFilterListsApiClient { private const string FilterListsApiBaseUrl = "https://filterlists.com/api/v1"; - private const string ExceptionMessage = "Error retrieving response from FilterLists API."; + private const string ExceptionMessage = "Error retrieving response from the FilterLists API."; private readonly IRestClient _restClient; public FilterListsApiClient()