From 3a8c9286a35d6ee7843cc829e0308034414fe079 Mon Sep 17 00:00:00 2001
From: "Collin M. Barrett" <collinbarrett@users.noreply.github.com>
Date: Fri, 5 Jul 2019 16:09:53 -0500
Subject: [PATCH] disable no longer relevant CA2007 warning for .NET Core apps

ref https://github.com/dotnet-architecture/eShopOnContainers/issues/515#issuecomment-469692449
---
 src/FilterLists.Agent/FilterLists.Agent.ruleset                | 2 +-
 src/FilterLists.Api/FilterLists.Api.ruleset                    | 3 ++-
 src/FilterLists.Data/FilterLists.Data.ruleset                  | 3 ++-
 src/FilterLists.Services/FilterLists.Services.ruleset          | 3 ++-
 src/FilterLists.Web/FilterLists.Web.ruleset                    | 3 ++-
 tests/FilterLists.Agent.Tests/FilterLists.Agent.Tests.ruleset  | 3 ++-
 tests/FilterLists.Data.Tests/FilterLists.Data.Tests.ruleset    | 3 ++-
 .../FilterLists.Services.Tests.ruleset                         | 3 ++-
 8 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/src/FilterLists.Agent/FilterLists.Agent.ruleset b/src/FilterLists.Agent/FilterLists.Agent.ruleset
index a85f49f33..f7e60da53 100644
--- a/src/FilterLists.Agent/FilterLists.Agent.ruleset
+++ b/src/FilterLists.Agent/FilterLists.Agent.ruleset
@@ -133,7 +133,7 @@
     <!-- Mark members as static -->
     <Rule Id="CA1823" Action="Warning" />
     <!-- Avoid unused private fields -->
-    <Rule Id="CA2007" Action="Warning" />
+    <Rule Id="CA2007" Action="None" /> <!-- https://stackoverflow.com/a/42058544 -->
     <!-- Consider calling ConfigureAwait on the awaited task -->
     <Rule Id="CA2119" Action="Warning" />
     <!-- Seal methods that satisfy private interfaces -->
diff --git a/src/FilterLists.Api/FilterLists.Api.ruleset b/src/FilterLists.Api/FilterLists.Api.ruleset
index a85f49f33..70352924b 100644
--- a/src/FilterLists.Api/FilterLists.Api.ruleset
+++ b/src/FilterLists.Api/FilterLists.Api.ruleset
@@ -133,7 +133,8 @@
     <!-- Mark members as static -->
     <Rule Id="CA1823" Action="Warning" />
     <!-- Avoid unused private fields -->
-    <Rule Id="CA2007" Action="Warning" />
+    <Rule Id="CA2007" Action="None" />
+    <!-- https://stackoverflow.com/a/42058544 -->
     <!-- Consider calling ConfigureAwait on the awaited task -->
     <Rule Id="CA2119" Action="Warning" />
     <!-- Seal methods that satisfy private interfaces -->
diff --git a/src/FilterLists.Data/FilterLists.Data.ruleset b/src/FilterLists.Data/FilterLists.Data.ruleset
index a85f49f33..70352924b 100644
--- a/src/FilterLists.Data/FilterLists.Data.ruleset
+++ b/src/FilterLists.Data/FilterLists.Data.ruleset
@@ -133,7 +133,8 @@
     <!-- Mark members as static -->
     <Rule Id="CA1823" Action="Warning" />
     <!-- Avoid unused private fields -->
-    <Rule Id="CA2007" Action="Warning" />
+    <Rule Id="CA2007" Action="None" />
+    <!-- https://stackoverflow.com/a/42058544 -->
     <!-- Consider calling ConfigureAwait on the awaited task -->
     <Rule Id="CA2119" Action="Warning" />
     <!-- Seal methods that satisfy private interfaces -->
diff --git a/src/FilterLists.Services/FilterLists.Services.ruleset b/src/FilterLists.Services/FilterLists.Services.ruleset
index a85f49f33..70352924b 100644
--- a/src/FilterLists.Services/FilterLists.Services.ruleset
+++ b/src/FilterLists.Services/FilterLists.Services.ruleset
@@ -133,7 +133,8 @@
     <!-- Mark members as static -->
     <Rule Id="CA1823" Action="Warning" />
     <!-- Avoid unused private fields -->
-    <Rule Id="CA2007" Action="Warning" />
+    <Rule Id="CA2007" Action="None" />
+    <!-- https://stackoverflow.com/a/42058544 -->
     <!-- Consider calling ConfigureAwait on the awaited task -->
     <Rule Id="CA2119" Action="Warning" />
     <!-- Seal methods that satisfy private interfaces -->
diff --git a/src/FilterLists.Web/FilterLists.Web.ruleset b/src/FilterLists.Web/FilterLists.Web.ruleset
index a85f49f33..70352924b 100644
--- a/src/FilterLists.Web/FilterLists.Web.ruleset
+++ b/src/FilterLists.Web/FilterLists.Web.ruleset
@@ -133,7 +133,8 @@
     <!-- Mark members as static -->
     <Rule Id="CA1823" Action="Warning" />
     <!-- Avoid unused private fields -->
-    <Rule Id="CA2007" Action="Warning" />
+    <Rule Id="CA2007" Action="None" />
+    <!-- https://stackoverflow.com/a/42058544 -->
     <!-- Consider calling ConfigureAwait on the awaited task -->
     <Rule Id="CA2119" Action="Warning" />
     <!-- Seal methods that satisfy private interfaces -->
diff --git a/tests/FilterLists.Agent.Tests/FilterLists.Agent.Tests.ruleset b/tests/FilterLists.Agent.Tests/FilterLists.Agent.Tests.ruleset
index a85f49f33..70352924b 100644
--- a/tests/FilterLists.Agent.Tests/FilterLists.Agent.Tests.ruleset
+++ b/tests/FilterLists.Agent.Tests/FilterLists.Agent.Tests.ruleset
@@ -133,7 +133,8 @@
     <!-- Mark members as static -->
     <Rule Id="CA1823" Action="Warning" />
     <!-- Avoid unused private fields -->
-    <Rule Id="CA2007" Action="Warning" />
+    <Rule Id="CA2007" Action="None" />
+    <!-- https://stackoverflow.com/a/42058544 -->
     <!-- Consider calling ConfigureAwait on the awaited task -->
     <Rule Id="CA2119" Action="Warning" />
     <!-- Seal methods that satisfy private interfaces -->
diff --git a/tests/FilterLists.Data.Tests/FilterLists.Data.Tests.ruleset b/tests/FilterLists.Data.Tests/FilterLists.Data.Tests.ruleset
index a85f49f33..70352924b 100644
--- a/tests/FilterLists.Data.Tests/FilterLists.Data.Tests.ruleset
+++ b/tests/FilterLists.Data.Tests/FilterLists.Data.Tests.ruleset
@@ -133,7 +133,8 @@
     <!-- Mark members as static -->
     <Rule Id="CA1823" Action="Warning" />
     <!-- Avoid unused private fields -->
-    <Rule Id="CA2007" Action="Warning" />
+    <Rule Id="CA2007" Action="None" />
+    <!-- https://stackoverflow.com/a/42058544 -->
     <!-- Consider calling ConfigureAwait on the awaited task -->
     <Rule Id="CA2119" Action="Warning" />
     <!-- Seal methods that satisfy private interfaces -->
diff --git a/tests/FilterLists.Services.Tests/FilterLists.Services.Tests.ruleset b/tests/FilterLists.Services.Tests/FilterLists.Services.Tests.ruleset
index a85f49f33..70352924b 100644
--- a/tests/FilterLists.Services.Tests/FilterLists.Services.Tests.ruleset
+++ b/tests/FilterLists.Services.Tests/FilterLists.Services.Tests.ruleset
@@ -133,7 +133,8 @@
     <!-- Mark members as static -->
     <Rule Id="CA1823" Action="Warning" />
     <!-- Avoid unused private fields -->
-    <Rule Id="CA2007" Action="Warning" />
+    <Rule Id="CA2007" Action="None" />
+    <!-- https://stackoverflow.com/a/42058544 -->
     <!-- Consider calling ConfigureAwait on the awaited task -->
     <Rule Id="CA2119" Action="Warning" />
     <!-- Seal methods that satisfy private interfaces -->