From 334666c335911e5da7074e399a89da6eea1e518d Mon Sep 17 00:00:00 2001
From: "Collin M. Barrett" <collinbarrett@users.noreply.github.com>
Date: Sat, 13 Oct 2018 11:39:38 -0500
Subject: [PATCH] add IsValidHttpOrHttpsUrlShould tests

---
 .../Collection/AddIfNotNullOrEmptyShould.cs   | 40 +++++++++++
 .../Extensions/Collection/AddRangeShould.cs   | 33 ++++++++++
 .../Extensions/CollectionExtensionShould.cs   | 66 -------------------
 .../String/IsValidHttpOrHttpsUrlShould.cs     | 29 ++++++++
 4 files changed, 102 insertions(+), 66 deletions(-)
 create mode 100644 tests/FilterLists.Services.Tests/Extensions/Collection/AddIfNotNullOrEmptyShould.cs
 create mode 100644 tests/FilterLists.Services.Tests/Extensions/Collection/AddRangeShould.cs
 delete mode 100644 tests/FilterLists.Services.Tests/Extensions/CollectionExtensionShould.cs
 create mode 100644 tests/FilterLists.Services.Tests/Extensions/String/IsValidHttpOrHttpsUrlShould.cs

diff --git a/tests/FilterLists.Services.Tests/Extensions/Collection/AddIfNotNullOrEmptyShould.cs b/tests/FilterLists.Services.Tests/Extensions/Collection/AddIfNotNullOrEmptyShould.cs
new file mode 100644
index 000000000..96917dd1d
--- /dev/null
+++ b/tests/FilterLists.Services.Tests/Extensions/Collection/AddIfNotNullOrEmptyShould.cs
@@ -0,0 +1,40 @@
+using System.Collections.Generic;
+using System.Collections.ObjectModel;
+using FilterLists.Services.Extensions;
+using Xunit;
+
+namespace FilterLists.Services.Tests.Extensions.Collection
+{
+    public class AddIfNotNullOrEmptyShould
+    {
+        public AddIfNotNullOrEmptyShould() =>
+            sut = new Collection<string>();
+
+        private readonly ICollection<string> sut;
+        private string item;
+
+        [Fact]
+        public void AddIfNotNullOrEmpty()
+        {
+            item = "item";
+            sut.AddIfNotNullOrEmpty(item);
+            Assert.Contains(item, sut);
+        }
+
+        [Fact]
+        public void NotAddIfEmpty()
+        {
+            item = "";
+            sut.AddIfNotNullOrEmpty(item);
+            Assert.DoesNotContain(item, sut);
+        }
+
+        [Fact]
+        public void NotAddIfNull()
+        {
+            item = null;
+            sut.AddIfNotNullOrEmpty(item);
+            Assert.DoesNotContain(item, sut);
+        }
+    }
+}
\ No newline at end of file
diff --git a/tests/FilterLists.Services.Tests/Extensions/Collection/AddRangeShould.cs b/tests/FilterLists.Services.Tests/Extensions/Collection/AddRangeShould.cs
new file mode 100644
index 000000000..15f8ca802
--- /dev/null
+++ b/tests/FilterLists.Services.Tests/Extensions/Collection/AddRangeShould.cs
@@ -0,0 +1,33 @@
+using System.Collections.Generic;
+using System.Collections.ObjectModel;
+using System.Linq;
+using FilterLists.Services.Extensions;
+using Xunit;
+
+namespace FilterLists.Services.Tests.Extensions.Collection
+{
+    public class AddRangeShould
+    {
+        public AddRangeShould() =>
+            sut = new Collection<string>();
+
+        private readonly ICollection<string> sut;
+        private IEnumerable<string> range;
+
+        [Fact]
+        public void AddCollectionOfStrings()
+        {
+            range = new Collection<string> {"item1", "item2"};
+            sut.AddRange(range);
+            Assert.True(!range.Except(sut).Any());
+        }
+
+        [Fact]
+        public void AddListOfStrings()
+        {
+            range = new List<string> {"item1", "item2"};
+            sut.AddRange(range);
+            Assert.True(!range.Except(sut).Any());
+        }
+    }
+}
\ No newline at end of file
diff --git a/tests/FilterLists.Services.Tests/Extensions/CollectionExtensionShould.cs b/tests/FilterLists.Services.Tests/Extensions/CollectionExtensionShould.cs
deleted file mode 100644
index 0b0befb8d..000000000
--- a/tests/FilterLists.Services.Tests/Extensions/CollectionExtensionShould.cs
+++ /dev/null
@@ -1,66 +0,0 @@
-using System.Collections.Generic;
-using System.Collections.ObjectModel;
-using System.Linq;
-using FilterLists.Services.Extensions;
-using Xunit;
-
-namespace FilterLists.Services.Tests.Extensions
-{
-    public abstract class CollectionExtensionShould
-    {
-        protected readonly ICollection<string> Sut;
-
-        protected CollectionExtensionShould() =>
-            Sut = new Collection<string>();
-    }
-
-    public class AddIfNotNullOrEmptyShould : CollectionExtensionShould
-    {
-        private string item;
-
-        [Fact]
-        public void AddIfNotNullOrEmpty()
-        {
-            item = "item";
-            Sut.AddIfNotNullOrEmpty(item);
-            Assert.Contains(item, Sut);
-        }
-
-        [Fact]
-        public void NotAddIfEmpty()
-        {
-            item = "";
-            Sut.AddIfNotNullOrEmpty(item);
-            Assert.DoesNotContain(item, Sut);
-        }
-
-        [Fact]
-        public void NotAddIfNull()
-        {
-            item = null;
-            Sut.AddIfNotNullOrEmpty(item);
-            Assert.DoesNotContain(item, Sut);
-        }
-    }
-
-    public class AddRangeShould : CollectionExtensionShould
-    {
-        private IEnumerable<string> range;
-
-        [Fact]
-        public void AddCollectionOfStrings()
-        {
-            range = new Collection<string> {"item1", "item2"};
-            Sut.AddRange(range);
-            Assert.True(!range.Except(Sut).Any());
-        }
-
-        [Fact]
-        public void AddListOfStrings()
-        {
-            range = new List<string> {"item1", "item2"};
-            Sut.AddRange(range);
-            Assert.True(!range.Except(Sut).Any());
-        }
-    }
-}
\ No newline at end of file
diff --git a/tests/FilterLists.Services.Tests/Extensions/String/IsValidHttpOrHttpsUrlShould.cs b/tests/FilterLists.Services.Tests/Extensions/String/IsValidHttpOrHttpsUrlShould.cs
new file mode 100644
index 000000000..ab932740c
--- /dev/null
+++ b/tests/FilterLists.Services.Tests/Extensions/String/IsValidHttpOrHttpsUrlShould.cs
@@ -0,0 +1,29 @@
+using FilterLists.Services.Extensions;
+using Xunit;
+
+namespace FilterLists.Services.Tests.Extensions.String
+{
+    public class IsValidHttpOrHttpsUrlShould
+    {
+        [Fact]
+        public void ReturnFalseIfNotHttpOrHttps()
+        {
+            const string abp = "abp://www.google.com";
+            Assert.False(abp.IsValidHttpOrHttpsUrl());
+        }
+
+        [Fact]
+        public void ReturnTrueIfValidHttpsUrl()
+        {
+            const string httpsUrl = "https://www.google.com";
+            Assert.True(httpsUrl.IsValidHttpOrHttpsUrl());
+        }
+
+        [Fact]
+        public void ReturnTrueIfValidHttpUrl()
+        {
+            const string httpUrl = "http://www.google.com";
+            Assert.True(httpUrl.IsValidHttpOrHttpsUrl());
+        }
+    }
+}
\ No newline at end of file