From 321bcf210bdfaf2e5e08d7055a45e526bd7de912 Mon Sep 17 00:00:00 2001 From: Collin Barrett <6483057+collinbarrett@users.noreply.github.com> Date: Sat, 28 Jun 2025 12:40:23 -0500 Subject: [PATCH] refactor(web): slim down unused props --- web/src/services/get-filterlists.ts | 15 ++------------- web/src/services/get-languages.ts | 8 +------- web/src/services/get-licenses.ts | 14 ++++---------- web/src/services/get-maintainers.ts | 12 +++--------- web/src/services/get-software.ts | 14 ++++---------- web/src/services/get-syntaxes.ts | 10 +--------- web/src/services/get-tags.ts | 8 +------- 7 files changed, 16 insertions(+), 65 deletions(-) diff --git a/web/src/services/get-filterlists.ts b/web/src/services/get-filterlists.ts index a2f924581..f37b579e9 100644 --- a/web/src/services/get-filterlists.ts +++ b/web/src/services/get-filterlists.ts @@ -8,7 +8,6 @@ export type FilterList = { syntaxIds: readonly number[]; languageIds: readonly number[]; tagIds: readonly number[]; - // primaryViewUrl: string | null; // TODO: rm from the API? maintainerIds: readonly number[]; }; @@ -18,18 +17,8 @@ export async function getFilterLists(): Promise { }); if (!response.ok) { - throw new Error(`Failed to fetch filter lists: ${response.statusText}`); + throw new Error(`Failed to fetch FilterLists: ${response.statusText}`); } - const data = await response.json(); - return data.map((item: Record) => ({ - id: item.id as number, - name: item.name as string, - description: item.description as string | null, - licenseId: item.licenseId as number, - syntaxIds: item.syntaxIds as readonly number[], - languageIds: item.languageIds as readonly number[], - tagIds: item.tagIds as readonly number[], - maintainerIds: item.maintainerIds as readonly number[], - })); + return await response.json(); } diff --git a/web/src/services/get-languages.ts b/web/src/services/get-languages.ts index 193b88652..eced512a2 100644 --- a/web/src/services/get-languages.ts +++ b/web/src/services/get-languages.ts @@ -4,7 +4,6 @@ export type Language = { id: number; iso6391: string; name: string; - // filterListIds: readonly number[]; // TODO: rm from the API? }; export async function getLanguages(): Promise { @@ -16,10 +15,5 @@ export async function getLanguages(): Promise { throw new Error(`Failed to fetch languages: ${response.statusText}`); } - const data = await response.json(); - return data.map((item: Record) => ({ - id: item.id as number, - iso6391: item.iso6391 as string, - name: item.name as string, - })); + return await response.json(); } diff --git a/web/src/services/get-licenses.ts b/web/src/services/get-licenses.ts index 541bc6b5e..8779d6416 100644 --- a/web/src/services/get-licenses.ts +++ b/web/src/services/get-licenses.ts @@ -4,10 +4,9 @@ export type License = { id: number; name: string; url: string | null; - // permitsModification: boolean; - // permitsDistribution: boolean; - // permitsCommercialUse: boolean; - // filterListIds: readonly number[]; // TODO: rm from the API? + permitsModification: boolean; + permitsDistribution: boolean; + permitsCommercialUse: boolean; }; export async function getLicenses(): Promise { @@ -19,10 +18,5 @@ export async function getLicenses(): Promise { throw new Error(`Failed to fetch licenses: ${response.statusText}`); } - const data = await response.json(); - return data.map((item: Record) => ({ - id: item.id as number, - name: item.name as string, - url: item.url as string | null, - })); + return await response.json(); } diff --git a/web/src/services/get-maintainers.ts b/web/src/services/get-maintainers.ts index 0e032a4a0..af755b9c9 100644 --- a/web/src/services/get-maintainers.ts +++ b/web/src/services/get-maintainers.ts @@ -4,9 +4,8 @@ export type Maintainer = { id: number; name: string; url: string | null; - // emailAddress: string | null; - // twitterHandle: string | null; - // filterListIds: readonly number[]; // TODO: rm from the API? + emailAddress: string | null; + twitterHandle: string | null; }; export async function getMaintainers(): Promise { @@ -18,10 +17,5 @@ export async function getMaintainers(): Promise { throw new Error(`Failed to fetch maintainers: ${response.statusText}`); } - const data = await response.json(); - return data.map((item: Record) => ({ - id: item.id as number, - name: item.name as string, - url: item.url as string | null, - })); + return await response.json(); } diff --git a/web/src/services/get-software.ts b/web/src/services/get-software.ts index 6de8c2e30..c92620c90 100644 --- a/web/src/services/get-software.ts +++ b/web/src/services/get-software.ts @@ -5,9 +5,9 @@ export type Software = { name: string; description: string | null; homeUrl: string | null; - // downloadUrl: string | null; - // supportsAbpUrlScheme: boolean; - // syntaxIds: readonly number[]; // TODO: rm from the API? + downloadUrl: string | null; + supportsAbpUrlScheme: boolean; + syntaxIds: readonly number[]; }; export async function getSoftware(): Promise { @@ -19,11 +19,5 @@ export async function getSoftware(): Promise { throw new Error(`Failed to fetch software: ${response.statusText}`); } - const data = await response.json(); - return data.map((item: Record) => ({ - id: item.id as number, - name: item.name as string, - description: item.description as string | null, - homeUrl: item.homeUrl as string | null, - })); + return await response.json(); } diff --git a/web/src/services/get-syntaxes.ts b/web/src/services/get-syntaxes.ts index 6497003cb..ef9b58075 100644 --- a/web/src/services/get-syntaxes.ts +++ b/web/src/services/get-syntaxes.ts @@ -5,8 +5,6 @@ export type Syntax = { name: string; description: string | null; url: string | null; - // filterListIds: readonly number[]; // TODO: rm from the API? - // softwareIds: readonly number[]; // TODO: rm from the API? }; export async function getSyntaxes(): Promise { @@ -18,11 +16,5 @@ export async function getSyntaxes(): Promise { throw new Error(`Failed to fetch syntaxes: ${response.statusText}`); } - const data = await response.json(); - return data.map((item: Record) => ({ - id: item.id as number, - name: item.name as string, - description: item.description as string | null, - url: item.url as string | null, - })); + return await response.json(); } diff --git a/web/src/services/get-tags.ts b/web/src/services/get-tags.ts index 562ec4a31..0878154e4 100644 --- a/web/src/services/get-tags.ts +++ b/web/src/services/get-tags.ts @@ -4,7 +4,6 @@ export type Tag = { id: number; name: string; description: string | null; - // filterListIds: readonly number[]; // TODO: rm from the API? }; export async function getTags(): Promise { @@ -16,10 +15,5 @@ export async function getTags(): Promise { throw new Error(`Failed to fetch tags: ${response.statusText}`); } - const data = await response.json(); - return data.map((item: Record) => ({ - id: item.id as number, - name: item.name as string, - description: item.description as string | null, - })); + return await response.json(); }