From 2f86f635ac6ebf5451c530a83e493051601b6536 Mon Sep 17 00:00:00 2001
From: "Collin M. Barrett" <collinbarrett@users.noreply.github.com>
Date: Sat, 13 Jul 2019 14:26:41 -0500
Subject: [PATCH] prefer transient registration

---
 .../ApplicationInsights/ServiceCollectionExtensions.cs      | 6 +++---
 .../Infrastructure/Polly/ServiceCollectionExtensions.cs     | 3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/FilterLists.Agent/Infrastructure/ApplicationInsights/ServiceCollectionExtensions.cs b/src/FilterLists.Agent/Infrastructure/ApplicationInsights/ServiceCollectionExtensions.cs
index ca4ee2cf1..951d8c63c 100644
--- a/src/FilterLists.Agent/Infrastructure/ApplicationInsights/ServiceCollectionExtensions.cs
+++ b/src/FilterLists.Agent/Infrastructure/ApplicationInsights/ServiceCollectionExtensions.cs
@@ -9,7 +9,7 @@ public static class ServiceCollectionExtensions
     {
         public static void AddApplicationInsights(this IServiceCollection services)
         {
-            services.AddSingleton(b =>
+            services.AddTransient(b =>
             {
                 var applicationInsightsSettings = b.GetService<IOptions<ApplicationInsightsSettings>>().Value;
                 return new TelemetryConfiguration
@@ -19,8 +19,8 @@ public static void AddApplicationInsights(this IServiceCollection services)
             });
             services.AddSingleton(b =>
             {
-                var configuration = b.GetService<TelemetryConfiguration>();
-                return new AgentTelemetryClient(configuration);
+                var telemetryConfiguration = b.GetService<TelemetryConfiguration>();
+                return new AgentTelemetryClient(telemetryConfiguration);
             });
             services.AddSingleton(b =>
             {
diff --git a/src/FilterLists.Agent/Infrastructure/Polly/ServiceCollectionExtensions.cs b/src/FilterLists.Agent/Infrastructure/Polly/ServiceCollectionExtensions.cs
index 52f64a75e..7cb71e975 100644
--- a/src/FilterLists.Agent/Infrastructure/Polly/ServiceCollectionExtensions.cs
+++ b/src/FilterLists.Agent/Infrastructure/Polly/ServiceCollectionExtensions.cs
@@ -27,7 +27,8 @@ await Task.Run(() =>
                             var logger = services.BuildServiceProvider().GetService<ILogger<IPolicyRegistry<string>>>();
                             logger.LogInformation("Retrying after 429 TooManyRequests",
                                 response.Result.RequestMessage.RequestUri,
-                                response.Result?.Headers.RetryAfter.Delta.ToString(), retryCount);
+                                response.Result?.Headers.RetryAfter.Delta.ToString(),
+                                retryCount);
                         });
                     });
             registry.Add(nameof(waitAndRetryTooManyRequests), waitAndRetryTooManyRequests);