From 29a2cc79f0f177791d6d9abe1a51c80ef941a216 Mon Sep 17 00:00:00 2001
From: "Collin M. Barrett" <collinbarrett@users.noreply.github.com>
Date: Tue, 2 Jul 2019 21:57:33 -0500
Subject: [PATCH] don't treat a redirect the same as being broken

---
 .../Features/Urls/ValidateUrls.cs              | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/src/FilterLists.Agent/Features/Urls/ValidateUrls.cs b/src/FilterLists.Agent/Features/Urls/ValidateUrls.cs
index 26e905b06..985154697 100644
--- a/src/FilterLists.Agent/Features/Urls/ValidateUrls.cs
+++ b/src/FilterLists.Agent/Features/Urls/ValidateUrls.cs
@@ -73,16 +73,22 @@ private TransformBlock<Uri, UrlValidationResult> BuildValidator(CancellationToke
                         try
                         {
                             var response = await _httpClient.GetAsync(u, cancellationToken);
-                            if (response.StatusCode == HttpStatusCode.PermanentRedirect ||
-                                response.StatusCode == HttpStatusCode.TemporaryRedirect)
-                                result.SetRedirectsTo(response.Headers.Location);
                             if (u.Scheme == Uri.UriSchemeHttp && await IsHttpsSupported(u, cancellationToken))
                                 result.SetSupportsHttps();
                             if (response.IsSuccessStatusCode)
                                 return result;
-                            result.SetBroken();
-                            _logger.LogError(
-                                $"Url validation for ({u.AbsoluteUri}) failed with status code: {response.StatusCode}.");
+                            if (response.StatusCode == HttpStatusCode.PermanentRedirect ||
+                                response.StatusCode == HttpStatusCode.TemporaryRedirect)
+                            {
+                                result.SetRedirectsTo(response.Headers.Location);
+                            }
+                            else
+                            {
+                                result.SetBroken();
+                                _logger.LogError(
+                                    $"Url validation for ({u.AbsoluteUri}) failed with status code: {response.StatusCode}.");
+                            }
+
                             return result;
                         }
                         catch (HttpRequestException ex)