From 0eacb2c7958ee01bfcb1c78dc8a617ad3d1b25cf Mon Sep 17 00:00:00 2001 From: "Collin M. Barrett" Date: Wed, 9 Sep 2020 21:15:18 -0500 Subject: [PATCH] =?UTF-8?q?refactor(directory):=20=E2=99=BB=20replace=20ha?= =?UTF-8?q?rd-coded=20connection=20string=20in=20seed=20test?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- docker-compose.directory.migrations.tests.yml | 2 ++ .../SeedQueryDbContextTest.cs | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docker-compose.directory.migrations.tests.yml b/docker-compose.directory.migrations.tests.yml index 47f403abd..d2b78e96b 100644 --- a/docker-compose.directory.migrations.tests.yml +++ b/docker-compose.directory.migrations.tests.yml @@ -10,6 +10,8 @@ services: - directory-migrations-tests-results:/tests/FilterLists.Directory.Infrastructure.Migrations.Tests/TestResults depends_on: - directory-db + environment: + ConnectionStrings__DirectoryConnection: ${DIRECTORY_CONNECTION_STRING} directory-db: image: postgres:alpine diff --git a/services/directory/tests/FilterLists.Directory.Infrastructure.Migrations.Tests/SeedQueryDbContextTest.cs b/services/directory/tests/FilterLists.Directory.Infrastructure.Migrations.Tests/SeedQueryDbContextTest.cs index befc73940..ae1c30ed3 100644 --- a/services/directory/tests/FilterLists.Directory.Infrastructure.Migrations.Tests/SeedQueryDbContextTest.cs +++ b/services/directory/tests/FilterLists.Directory.Infrastructure.Migrations.Tests/SeedQueryDbContextTest.cs @@ -1,3 +1,4 @@ +using System; using System.Threading.Tasks; using FilterLists.Directory.Infrastructure.Migrations.Migrations; using FilterLists.Directory.Infrastructure.Persistence.Queries.Context; @@ -13,7 +14,8 @@ public async Task Migrate_DoesNotThrowException() { var exception = await Record.ExceptionAsync(async () => { - const string connString = "Server=directory-db;Database=filterlists;Uid=filterlists;Pwd=filterlists;"; + var connString = Environment.GetEnvironmentVariable("ConnectionStrings__DirectoryConnection") ?? + throw new Exception(); var options = new DbContextOptionsBuilder() .UseNpgsql(connString, m => m.MigrationsAssembly(typeof(Initial).Assembly.GetName().Name)) .EnableSensitiveDataLogging()